From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Greg KH <gregkh@suse.de>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Lin Ming <ming.m.lin@intel.com>, Len Brown <lenb@kernel.org>
Subject: [PATCH] Fix key f70f4b50 not in .data in thermal_sys
Date: Mon, 22 Mar 2010 15:15:08 +0200 [thread overview]
Message-ID: <20100322131508.GB3596@swordfish.minsk.epam.com> (raw)
In-Reply-To: <20100309141826.GC28606@suse.de>
[-- Attachment #1: Type: text/plain, Size: 1335 bytes --]
Initialize sysfs attributes before device_create_file call.
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
index 5066de5..a76a6ff 100644
--- a/drivers/thermal/thermal_sys.c
+++ b/drivers/thermal/thermal_sys.c
@@ -492,6 +492,7 @@ thermal_add_hwmon_sysfs(struct thermal_zone_device *tz)
goto free_mem;
}
dev_set_drvdata(hwmon->device, hwmon);
+ sysfs_attr_init(&dev_attr_name.attr);
result = device_create_file(hwmon->device, &dev_attr_name);
if (result)
goto unregister_hwmon_device;
@@ -505,6 +506,7 @@ thermal_add_hwmon_sysfs(struct thermal_zone_device *tz)
tz->temp_input.attr.attr.name = tz->temp_input.name;
tz->temp_input.attr.attr.mode = 0444;
tz->temp_input.attr.show = temp_input_show;
+ sysfs_attr_init(&tz->temp_input.attr.attr);
result = device_create_file(hwmon->device, &tz->temp_input.attr);
if (result)
goto unregister_hwmon_device;
@@ -517,6 +519,7 @@ thermal_add_hwmon_sysfs(struct thermal_zone_device *tz)
tz->temp_crit.attr.attr.name = tz->temp_crit.name;
tz->temp_crit.attr.attr.mode = 0444;
tz->temp_crit.attr.show = temp_crit_show;
+ sysfs_attr_init(&tz->temp_crit.attr.attr);
result = device_create_file(hwmon->device,
&tz->temp_crit.attr);
if (result)
[-- Attachment #2: Type: application/pgp-signature, Size: 316 bytes --]
next prev parent reply other threads:[~2010-03-22 13:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 10:27 BUG: key f70f4b50 not in .data Sergey Senozhatsky
2010-03-09 14:18 ` Greg KH
2010-03-22 13:15 ` Sergey Senozhatsky [this message]
2010-03-22 13:31 ` [PATCH] Fix key f70f4b50 not in .data in thermal_sys Wolfram Sang
2010-03-22 13:54 ` Sergey Senozhatsky
2010-03-22 13:52 ` Sergey Senozhatsky
2010-03-22 14:07 ` Wolfram Sang
2010-03-22 14:45 ` [PATCH] Fix key f70f4b50 not in .data in thermal_sys V2 Sergey Senozhatsky
2010-04-05 0:17 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100322131508.GB3596@swordfish.minsk.epam.com \
--to=sergey.senozhatsky@gmail.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox