From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Date: Wed, 31 Mar 2010 09:30:04 +0200 Message-ID: <20100331093004.5143415f@hyperion.delvare> References: <20100309135636.373a40a9@hyperion.delvare> <20100330120319.627e8f9a@hyperion.delvare> <20100330132132.GA16657@srcf.ucam.org> <20100330214732.42f488ba@hyperion.delvare> <20100330194835.GA32322@srcf.ucam.org> <20100330223251.76c6b000@hyperion.delvare> <20100330211049.GA1524@srcf.ucam.org> <68676e01003301445v1b3ee070nfc0f0b53716c4740@mail.gmail.com> <20100330215305.GA2220@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from bamako.nerim.net ([62.4.17.28]:55969 "EHLO bamako.nerim.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756700Ab0CaHaH (ORCPT ); Wed, 31 Mar 2010 03:30:07 -0400 In-Reply-To: <20100330215305.GA2220@srcf.ucam.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Matthew Garrett Cc: Luca Tettamanti , linux-acpi@vger.kernel.org, Len Brown , LM Sensors On Tue, 30 Mar 2010 22:53:05 +0100, Matthew Garrett wrote: > On Tue, Mar 30, 2010 at 11:45:46PM +0200, Luca Tettamanti wrote: > > On Tue, Mar 30, 2010 at 11:10 PM, Matthew Garrett wrote: > > > Because the situation with the asus driver loaded isn't obviously any > > > worse than not having it loaded. The user is telling us that they're > > > happy with racy access to their hwmon hardware. > > > > "lax" option is typically used when the user wants to load the native > > driver; in this case we know that it's not safe to load asus driver. > > It's not safe to load the native driver, full stop. Not loading the asus > driver doesn't alter that. It definitely does. At least on some of the affected boards, no access to the I/O area in question is done at all as long as the asus_atk0110 driver is not loaded. So it is actually safe to pass acpi_enforce_resources=lax and not load the asus_atk0110 driver. And people are actually doing this because native drivers can control the speed of their fans while the asus_atk0110 driver can't. So they see the current situation as a regression. Again, can you please point to problems my patch has? -- Jean Delvare