From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Date: Wed, 31 Mar 2010 14:27:11 +0100 Message-ID: <20100331132711.GA17104@srcf.ucam.org> References: <20100330132132.GA16657@srcf.ucam.org> <20100330214732.42f488ba@hyperion.delvare> <20100330194835.GA32322@srcf.ucam.org> <20100330223251.76c6b000@hyperion.delvare> <20100330211049.GA1524@srcf.ucam.org> <68676e01003301445v1b3ee070nfc0f0b53716c4740@mail.gmail.com> <20100330215305.GA2220@srcf.ucam.org> <20100331093004.5143415f@hyperion.delvare> <20100331125122.GA16583@srcf.ucam.org> <20100331152500.4b2ef6a0@hyperion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:55201 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757691Ab0CaN1O (ORCPT ); Wed, 31 Mar 2010 09:27:14 -0400 Content-Disposition: inline In-Reply-To: <20100331152500.4b2ef6a0@hyperion.delvare> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Jean Delvare Cc: Luca Tettamanti , linux-acpi@vger.kernel.org, Len Brown , LM Sensors On Wed, Mar 31, 2010 at 03:25:00PM +0200, Jean Delvare wrote: > On Wed, 31 Mar 2010 13:51:23 +0100, Matthew Garrett wrote: > > On Wed, Mar 31, 2010 at 09:30:04AM +0200, Jean Delvare wrote: > > > > > It definitely does. At least on some of the affected boards, no access > > > to the I/O area in question is done at all as long as the asus_atk0110 > > > driver is not loaded. > > > > You've audited the system management code? > > No, I did not. But you did not review the system management code of all > computers out there either, and you are still writing kernel code that > could be broken by it. So what's the point? If the firmware tells us that a resource range using indexed access is reserved, it's not safe to assume that the firmware isn't using it. -- Matthew Garrett | mjg59@srcf.ucam.org