From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shaohua Li Subject: Re: [patch v2] acpi_pad: "processor_aggregator" name too long Date: Tue, 6 Apr 2010 09:21:13 +0800 Message-ID: <20100406012113.GA18672@sli10-desk.sh.intel.com> References: <20100319114806.GN5331@bicker> <20100325142738.GD1602@ucw.cz> <20100325144122.GF5069@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga01.intel.com ([192.55.52.88]:31285 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756236Ab0DFBVQ (ORCPT ); Mon, 5 Apr 2010 21:21:16 -0400 Content-Disposition: inline In-Reply-To: <20100325144122.GF5069@bicker> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Dan Carpenter , Pavel Machek , Len Brown , Andrew Morton , Chen Gong , Peter On Thu, Mar 25, 2010 at 10:41:22PM +0800, Dan Carpenter wrote: > cpi_device_class can only be 19 characters and a NULL terminator. > > With the current name we get a buffer overflow in acpi_pad_add() > strcpy(acpi_device_class(device), ACPI_PROCESSOR_AGGREGATOR_CLASS); > > Signed-off-by: Dan Carpenter > --- > V2: Thanks to Pavel Machek for coming up with the right name for this. > > diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c > index 7e52295..790aaa1 100644 > --- a/drivers/acpi/acpi_pad.c > +++ b/drivers/acpi/acpi_pad.c > @@ -30,7 +30,7 @@ > #include > #include > > -#define ACPI_PROCESSOR_AGGREGATOR_CLASS "processor_aggregator" > +#define ACPI_PROCESSOR_AGGREGATOR_CLASS "cpu_aggregator" > #define ACPI_PROCESSOR_AGGREGATOR_DEVICE_NAME "Processor Aggregator" > #define ACPI_PROCESSOR_AGGREGATOR_NOTIFY 0x80 > static DEFINE_MUTEX(isolated_cpus_lock); sorry for being later to reply. Better the name could be 'acpi_pad', which is what the spec called. cpu_aggregator looks like a invented name. Thanks, Shaohua