From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Jerone Young <jerone.young@canonical.com>
Cc: Alex Chiang <achiang@canonical.com>,
lenb@kernel.org, colin.king@canonical.com,
linux-acpi@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
stable@kernel.org
Subject: Re: [PATCH] ACPI: DMI init_set_sci_en_on_resume for multiple Lenovo ThinkPads
Date: Tue, 20 Apr 2010 18:14:15 +0100 [thread overview]
Message-ID: <20100420171415.GA9550@srcf.ucam.org> (raw)
In-Reply-To: <1271782601.25170.105.camel@laptop>
On Tue, Apr 20, 2010 at 11:56:41AM -0500, Jerone Young wrote:
> Don't think this patch should go in as Lenovo is issuing a BIOS to
> address this issue. On these Thinkpads listed and more. Seems to add
> uneeded quirks in my opinion.
>
> Though some over all patch may be good for all machines. As Windows
> seems to be setting this bit on it's own.
It's a perfectly safe workaround that's limited to a well-bounded set of
machines and fixes a pretty serious problem with them. While I'd prefer
my approach and then a removal of the existing quirk entries, Alex's
patch makes more sense for stable. The BIOS update is as yet unreleased,
requires either Windows or an optical drive (which some of these
machines don't have) and is a far from discoverable solution to the
issue.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-04-20 17:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 14:03 [PATCH] ACPI: DMI init_set_sci_en_on_resume for multiple Lenovo ThinkPads Alex Chiang
2010-04-20 14:46 ` Matthew Garrett
2010-04-20 14:54 ` Alex Chiang
2010-04-20 16:56 ` Jerone Young
2010-04-20 17:14 ` Matthew Garrett [this message]
2010-04-20 17:18 ` Jerone Young
2010-04-20 17:24 ` Matthew Garrett
2010-04-20 19:01 ` Rafael J. Wysocki
2010-04-20 17:20 ` Alex Chiang
2010-04-22 20:41 ` Alex Chiang
2010-05-05 20:34 ` Len Brown
2010-05-05 22:42 ` Alex Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100420171415.GA9550@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=achiang@canonical.com \
--cc=colin.king@canonical.com \
--cc=jerone.young@canonical.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).