From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [patch] acpi: silence kmemcheck false positive Date: Thu, 22 Apr 2010 22:02:20 +0200 Message-ID: <20100422200220.GC29093@bicker> References: <20100422194346.GB29093@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-wy0-f174.google.com ([74.125.82.174]:49077 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932140Ab0DVUCq (ORCPT ); Thu, 22 Apr 2010 16:02:46 -0400 Received: by wyb39 with SMTP id 39so5115978wyb.19 for ; Thu, 22 Apr 2010 13:02:45 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20100422194346.GB29093@bicker> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Len Brown Cc: Bjorn Helgaas , Shaohua Li , Zhang Rui , Zhao Yakui , linux-acpi@vger.kernel.org, vegardno@ifi.uio.no, casteyde.christian@free.fr Oops. I forgot to add Christian to the CC list. Added. regards, dan carpenter On Thu, Apr 22, 2010 at 09:43:46PM +0200, Dan Carpenter wrote: > This addresses: https://bugzilla.kernel.org/show_bug.cgi?id=14998 > > We copy some strings into "event" and kmemcheck complains that the bytes > after the NULL terminators are uninitialized. That's true but it's > harmless. The "event" struct is used in acpi_system_read_event() and we > don't read past the terminator. > > This patch just silences the warning. > > Reported-by: Christian Casteyde > Signed-off-by: Dan Carpenter > Tested-by: Christian Casteyde > > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c > index 37132dc..4ef7c97 100644 > --- a/drivers/acpi/bus.c > +++ b/drivers/acpi/bus.c > @@ -527,7 +527,7 @@ int acpi_bus_generate_proc_event4(const char *device_class, const char *bus_id, > if (!event_is_open) > return 0; > > - event = kmalloc(sizeof(struct acpi_bus_event), GFP_ATOMIC); > + event = kmalloc(sizeof(struct acpi_bus_event), GFP_ATOMIC | __GFP_NOTRACK_FALSE_POSITIVE); > if (!event) > return -ENOMEM; >