linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Chiang <achiang@canonical.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Matthew Garrett <mjg@redhat.com>,
	linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
	rjw@sisk.pl, stable@kernel.org
Subject: Re: [PATCH] pci: Ensure we re-enable devices on resume
Date: Thu, 22 Apr 2010 17:46:53 -0600	[thread overview]
Message-ID: <20100422234653.GA4388@canonical.com> (raw)
In-Reply-To: <20100422161735.28dcc8b9@virtuousgeek.org>

* Jesse Barnes <jbarnes@virtuousgeek.org>:
> On Thu, 22 Apr 2010 09:30:51 -0400
> Matthew Garrett <mjg@redhat.com> wrote:
> 
> > If the firmware puts a device back into D0 state at resume time, we'll
> > update its state in resume_noirq and thus skip the platform resume code.
> > Calling that code twice should be safe and we ought to avoid getting to
> > that point anyway, so remove the check and also allow the platform pci
> > code to be called for D0.
> > 
> > Fixes USB not being powered after resume on recent Lenovo machines.
> > 
> > Signed-off-by: Matthew Garrett <mjg@redhat.com>
> 
> Applied to for-linus, thanks.

Thanks Jesse. 

Stable, can you please pick this up too?

The original commit that introduced the thinko was 4a865905.

achiang@aspen:~/kernels/linux-2.6$ git describe --contains 4a865905
v2.6.30-rc1~609^2~4

which looks like it was introduced in 2.6.30, but I'd be happy with
just hitting v2.6.32, since this is what just about every distro
has settled on these days.

Thanks,
/ac

  reply	other threads:[~2010-04-22 23:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-22 13:30 [PATCH] pci: Ensure we re-enable devices on resume Matthew Garrett
2010-04-22 18:14 ` Rafael J. Wysocki
2010-04-22 19:43 ` Alex Chiang
2010-04-22 23:17 ` Jesse Barnes
2010-04-22 23:46   ` Alex Chiang [this message]
2010-04-23  0:08     ` [stable] " Greg KH
2010-04-25  4:21       ` Alex Chiang
2010-05-07 20:43         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100422234653.GA4388@canonical.com \
    --to=achiang@canonical.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=rjw@sisk.pl \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).