From: Dan Carpenter <error27@gmail.com>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Len Brown <lenb@kernel.org>, Shaohua Li <shaohua.li@intel.com>,
Zhang Rui <rui.zhang@intel.com>,
Zhao Yakui <yakui.zhao@intel.com>,
linux-acpi@vger.kernel.org, vegardno@ifi.uio.no,
casteyde.christian@free.fr
Subject: Re: [patch] acpi: silence kmemcheck false positive
Date: Fri, 23 Apr 2010 21:17:14 +0200 [thread overview]
Message-ID: <20100423191714.GJ29093@bicker> (raw)
In-Reply-To: <201004221632.21129.bjorn.helgaas@hp.com>
On Thu, Apr 22, 2010 at 04:32:20PM -0600, Bjorn Helgaas wrote:
> > > - event = kmalloc(sizeof(struct acpi_bus_event), GFP_ATOMIC);
> > > + event = kmalloc(sizeof(struct acpi_bus_event), GFP_ATOMIC | __GFP_NOTRACK_FALSE_POSITIVE);
>
> Just in terms of reading the code, this solution is fairly ugly.
> I think __GFP_NOTRACK should be sort of the last resort, after we've
> ruled out all the more conventional strategies.
>
> Has anybody tried any of the alternatives Vegard suggested here:
> https://bugzilla.kernel.org/show_bug.cgi?id=14998#c35 ?
Another potential solution would be to change the kmalloc() to a
kzalloc().
This isn't really my code, I was just randomly poking through bugzilla.
Tell me which approach you prefer and I'll do it.
regards,
dan carpenter
next prev parent reply other threads:[~2010-04-23 19:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 19:43 [patch] acpi: silence kmemcheck false positive Dan Carpenter
2010-04-22 20:02 ` Dan Carpenter
2010-04-22 22:32 ` Bjorn Helgaas
2010-04-23 19:17 ` Dan Carpenter [this message]
2010-04-26 22:19 ` Dan Carpenter
2010-04-26 22:23 ` [patch v2] " Dan Carpenter
2010-04-27 7:15 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100423191714.GJ29093@bicker \
--to=error27@gmail.com \
--cc=bjorn.helgaas@hp.com \
--cc=casteyde.christian@free.fr \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=shaohua.li@intel.com \
--cc=vegardno@ifi.uio.no \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).