linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: "H. Peter Anvin" <hpa@zytor.com>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	Len Brown <lenb@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: [PATCH 0/2] PNPACPI, x86/PCI: handle _CRS windows like Windows does
Date: Tue, 27 Apr 2010 14:45:33 -0600	[thread overview]
Message-ID: <20100427202122.23753.63421.stgit@bob.kio> (raw)

These patches simplify the way we handle Address Space descriptors and make
Linux do it more like Windows does.

The PNPACPI change is definitely .35 material, since I don't think anybody
uses this information via PNP yet.

My first thought was that the x86/PCI change is for .35, too, but it does
make a difference in some cases, so maybe it should go in .34.

Here's an example where it matters.  ACPI _CRS could have an MMIO Address Space
descriptor like this:

  _MIN 0xE0000000
  _MAX 0xFEBFFFFF
  _LEN 0x10000000,

which doesn't satisfy the spec requirement that:

  _MAX == _MIN + _LEN - 1,

but obviously we can't rely on spec compliance.  These are the ways we could
interpret it:

  [mem 0xe0000000-0xefffffff] current Linux way (end is _MIN + _LEN - 1)
  [mem 0xe0000000-0xfebfffff] new Linux way (end is _MAX)
  [mem 0xe0000000-0xfebfffff] Windows way (end is _MAX)

The risk is that BIOS might have placed a PCI device in the area that we used
to think was illegal, i.e., anywhere in [mem 0xf0000000-0xfebfffff], and Linux
will try to move the device unnecessarily, and that move might fail.

---

Bjorn Helgaas (2):
      PNPACPI: compute Address Space length rather than using _LEN
      x86/PCI: compute Address Space length rather than using _LEN

 arch/x86/pci/acpi.c            |   40 ++--------------------------------------
 drivers/pnp/pnpacpi/rsparser.c |   26 ++++----------------------
 2 files changed, 6 insertions(+), 60 deletions(-)

             reply	other threads:[~2010-04-27 20:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-27 20:45 Bjorn Helgaas [this message]
2010-04-27 20:45 ` [PATCH 1/2] PNPACPI: compute Address Space length rather than using _LEN Bjorn Helgaas
2010-04-27 20:45 ` [PATCH 2/2] x86/PCI: " Bjorn Helgaas
2010-04-29  1:48 ` [PATCH 0/2] PNPACPI, x86/PCI: handle _CRS windows like Windows does Len Brown
2010-04-29 15:42   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100427202122.23753.63421.stgit@bob.kio \
    --to=bjorn.helgaas@hp.com \
    --cc=hpa@zytor.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).