* [patch 4/4] acpi_pad: "processor_aggregator" name too long
@ 2010-04-27 21:06 akpm
2010-04-29 0:07 ` Len Brown
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2010-04-27 21:06 UTC (permalink / raw)
To: lenb; +Cc: linux-acpi, akpm, error27, pavel, shaohua.li, wharms
From: Dan Carpenter <error27@gmail.com>
cpi_device_class can only be 19 characters and a NULL terminator.
With the current name we get a buffer overflow in acpi_pad_add()
strcpy(acpi_device_class(device), ACPI_PROCESSOR_AGGREGATOR_CLASS);
[akpm@linux-foundation.org: call it acpi_pad, per Shaohua Li]
Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: walter harms <wharms@bfs.de>
Cc: Shaohua Li <shaohua.li@intel.com>
Cc: Len Brown <lenb@kernel.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/acpi/acpi_pad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/acpi/acpi_pad.c~acpi_pad-processor_aggregator-name-too-long drivers/acpi/acpi_pad.c
--- a/drivers/acpi/acpi_pad.c~acpi_pad-processor_aggregator-name-too-long
+++ a/drivers/acpi/acpi_pad.c
@@ -31,7 +31,7 @@
#include <acpi/acpi_bus.h>
#include <acpi/acpi_drivers.h>
-#define ACPI_PROCESSOR_AGGREGATOR_CLASS "processor_aggregator"
+#define ACPI_PROCESSOR_AGGREGATOR_CLASS "acpi_pad"
#define ACPI_PROCESSOR_AGGREGATOR_DEVICE_NAME "Processor Aggregator"
#define ACPI_PROCESSOR_AGGREGATOR_NOTIFY 0x80
static DEFINE_MUTEX(isolated_cpus_lock);
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 4/4] acpi_pad: "processor_aggregator" name too long
2010-04-27 21:06 [patch 4/4] acpi_pad: "processor_aggregator" name too long akpm
@ 2010-04-29 0:07 ` Len Brown
0 siblings, 0 replies; 2+ messages in thread
From: Len Brown @ 2010-04-29 0:07 UTC (permalink / raw)
To: akpm; +Cc: linux-acpi, error27, pavel, shaohua.li, wharms
applied
thanks,
Len Brown, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-01 1:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-27 21:06 [patch 4/4] acpi_pad: "processor_aggregator" name too long akpm
2010-04-29 0:07 ` Len Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).