* Re: linux-next: Tree for May 6 (acpi: PM=n) [not found] <20100506151502.f97afe54.sfr@canb.auug.org.au> @ 2010-05-06 15:05 ` Randy Dunlap 2010-05-06 20:26 ` [linux-pm] " Len Brown 2010-05-06 15:07 ` linux-next: Tree for May 6 (acpi: PCI=n) Randy Dunlap 1 sibling, 1 reply; 8+ messages in thread From: Randy Dunlap @ 2010-05-06 15:05 UTC (permalink / raw) To: Stephen Rothwell, linux-pm; +Cc: linux-next, LKML, linux-acpi On Thu, 6 May 2010 15:15:02 +1000 Stephen Rothwell wrote: > Hi all, > > Changes since 20100505: When CONFIG_PM is not set: drivers/built-in.o: In function `acpi_init': bus.c:(.init.text+0x2d84): undefined reference to `pm_flags' bus.c:(.init.text+0x2d91): undefined reference to `pm_flags' --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [linux-pm] linux-next: Tree for May 6 (acpi: PM=n) 2010-05-06 15:05 ` linux-next: Tree for May 6 (acpi: PM=n) Randy Dunlap @ 2010-05-06 20:26 ` Len Brown 2010-05-06 20:32 ` Randy Dunlap 0 siblings, 1 reply; 8+ messages in thread From: Len Brown @ 2010-05-06 20:26 UTC (permalink / raw) To: Randy Dunlap; +Cc: Stephen Rothwell, linux-pm, linux-acpi, linux-next, LKML > When CONFIG_PM is not set: > > drivers/built-in.o: In function `acpi_init': > bus.c:(.init.text+0x2d84): undefined reference to `pm_flags' > bus.c:(.init.text+0x2d91): undefined reference to `pm_flags' CONFIG_ACPI depends on CONFIG_PM, so acpi/bus.c should not be compiled for CONFIG_PM=n Hmm, is is somebody doing something strange, like "select ACPI" without guaranteeing that all of ACPI's dependencies are satisfied? thanks, Len Brown, Intel Open Source Technology Center ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [linux-pm] linux-next: Tree for May 6 (acpi: PM=n) 2010-05-06 20:26 ` [linux-pm] " Len Brown @ 2010-05-06 20:32 ` Randy Dunlap 2010-05-06 23:27 ` James Morris 0 siblings, 1 reply; 8+ messages in thread From: Randy Dunlap @ 2010-05-06 20:32 UTC (permalink / raw) To: Len Brown, James Morris Cc: Stephen Rothwell, linux-pm, linux-acpi, linux-next, LKML On Thu, 06 May 2010 16:26:13 -0400 (EDT) Len Brown wrote: > > When CONFIG_PM is not set: > > > > drivers/built-in.o: In function `acpi_init': > > bus.c:(.init.text+0x2d84): undefined reference to `pm_flags' > > bus.c:(.init.text+0x2d91): undefined reference to `pm_flags' > > CONFIG_ACPI depends on CONFIG_PM, > so acpi/bus.c should not be compiled for CONFIG_PM=n > > Hmm, is is somebody doing something strange, like "select ACPI" > without guaranteeing that all of ACPI's dependencies are satisfied? Oh, thanks for the clue. That would be a patch that I commented on and was ignored, but James Morris merged it anyway. Now it should be dropped. http://lkml.org/lkml/2010/5/4/379 --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [linux-pm] linux-next: Tree for May 6 (acpi: PM=n) 2010-05-06 20:32 ` Randy Dunlap @ 2010-05-06 23:27 ` James Morris 2010-05-06 23:38 ` Randy Dunlap 0 siblings, 1 reply; 8+ messages in thread From: James Morris @ 2010-05-06 23:27 UTC (permalink / raw) To: Randy Dunlap Cc: Len Brown, Stephen Rothwell, linux-pm, linux-acpi, linux-next, LKML, Mimi Zohar, Rajiv Andrade On Thu, 6 May 2010, Randy Dunlap wrote: > On Thu, 06 May 2010 16:26:13 -0400 (EDT) Len Brown wrote: > > > > When CONFIG_PM is not set: > > > > > > drivers/built-in.o: In function `acpi_init': > > > bus.c:(.init.text+0x2d84): undefined reference to `pm_flags' > > > bus.c:(.init.text+0x2d91): undefined reference to `pm_flags' > > > > CONFIG_ACPI depends on CONFIG_PM, > > so acpi/bus.c should not be compiled for CONFIG_PM=n > > > > Hmm, is is somebody doing something strange, like "select ACPI" > > without guaranteeing that all of ACPI's dependencies are satisfied? > > Oh, thanks for the clue. > > That would be a patch that I commented on and was ignored, > but James Morris merged it anyway. Now it should be dropped. > > http://lkml.org/lkml/2010/5/4/379 You weren't ignored. Mimi responded and mentioned a subsequent patch, after which, there was no further discussion. I've reverted: b89e66e1e396f7b5436af154e58209320cc08aed "TPM: ACPI/PNP dependency removal" a674fa46c79ffa37995bd1c8e4daa2b3be5a95ae "ima: remove ACPI dependency" Note: any further ACPI-related changes here should have acks from linux-acpi folk. - James -- James Morris <jmorris@namei.org> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [linux-pm] linux-next: Tree for May 6 (acpi: PM=n) 2010-05-06 23:27 ` James Morris @ 2010-05-06 23:38 ` Randy Dunlap 0 siblings, 0 replies; 8+ messages in thread From: Randy Dunlap @ 2010-05-06 23:38 UTC (permalink / raw) To: James Morris Cc: Len Brown, Stephen Rothwell, linux-pm, linux-acpi, linux-next, LKML, Mimi Zohar, Rajiv Andrade On 05/06/10 16:27, James Morris wrote: > On Thu, 6 May 2010, Randy Dunlap wrote: > >> On Thu, 06 May 2010 16:26:13 -0400 (EDT) Len Brown wrote: >> >>>> When CONFIG_PM is not set: >>>> >>>> drivers/built-in.o: In function `acpi_init': >>>> bus.c:(.init.text+0x2d84): undefined reference to `pm_flags' >>>> bus.c:(.init.text+0x2d91): undefined reference to `pm_flags' >>> >>> CONFIG_ACPI depends on CONFIG_PM, >>> so acpi/bus.c should not be compiled for CONFIG_PM=n >>> >>> Hmm, is is somebody doing something strange, like "select ACPI" >>> without guaranteeing that all of ACPI's dependencies are satisfied? >> >> Oh, thanks for the clue. >> >> That would be a patch that I commented on and was ignored, >> but James Morris merged it anyway. Now it should be dropped. >> >> http://lkml.org/lkml/2010/5/4/379 > > You weren't ignored. Mimi responded and mentioned a subsequent patch, > after which, there was no further discussion. OK. But merging a known bad patch doesn't make much sense to me. > I've reverted: > > b89e66e1e396f7b5436af154e58209320cc08aed > "TPM: ACPI/PNP dependency removal" > > a674fa46c79ffa37995bd1c8e4daa2b3be5a95ae > "ima: remove ACPI dependency" > Thanks. > > Note: any further ACPI-related changes here should have acks from > linux-acpi folk. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: linux-next: Tree for May 6 (acpi: PCI=n) [not found] <20100506151502.f97afe54.sfr@canb.auug.org.au> 2010-05-06 15:05 ` linux-next: Tree for May 6 (acpi: PM=n) Randy Dunlap @ 2010-05-06 15:07 ` Randy Dunlap 2010-05-06 20:29 ` Len Brown 1 sibling, 1 reply; 8+ messages in thread From: Randy Dunlap @ 2010-05-06 15:07 UTC (permalink / raw) To: Stephen Rothwell, linux-acpi; +Cc: linux-next, LKML On Thu, 6 May 2010 15:15:02 +1000 Stephen Rothwell wrote: > Hi all, > > Changes since 20100505: When CONFIG_PCI is not enabled: arch/x86/kernel/acpi/boot.c:1034: error: 'pci_bus_type' undeclared drivers/acpi/reboot.c:30: error:implicit declaration of function 'pci_find_bus' drivers/acpi/reboot.c:30: warning: assignment makes pointer from integer without a cast drivers/acpi/reboot.c:38: error:implicit declaration of function 'pci_bus_write_config_byte' --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: linux-next: Tree for May 6 (acpi: PCI=n) 2010-05-06 15:07 ` linux-next: Tree for May 6 (acpi: PCI=n) Randy Dunlap @ 2010-05-06 20:29 ` Len Brown 2010-05-06 20:42 ` Randy Dunlap 0 siblings, 1 reply; 8+ messages in thread From: Len Brown @ 2010-05-06 20:29 UTC (permalink / raw) To: Randy Dunlap; +Cc: Stephen Rothwell, linux-acpi, linux-next, LKML > When CONFIG_PCI is not enabled: > > arch/x86/kernel/acpi/boot.c:1034: error: 'pci_bus_type' undeclared > > drivers/acpi/reboot.c:30: error:implicit declaration of function 'pci_find_bus' > drivers/acpi/reboot.c:30: warning: assignment makes pointer from integer without a cast > drivers/acpi/reboot.c:38: error:implicit declaration of function 'pci_bus_write_config_byte' CONFIG_ACPI depends on CONFIG_PCI, so this file should not be build with CONFIG_PCI=n. Please let me know how you were able to generate this illegal configuration. thanks, Len Brown, Intel Open Source Technology Center ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: linux-next: Tree for May 6 (acpi: PCI=n) 2010-05-06 20:29 ` Len Brown @ 2010-05-06 20:42 ` Randy Dunlap 0 siblings, 0 replies; 8+ messages in thread From: Randy Dunlap @ 2010-05-06 20:42 UTC (permalink / raw) To: Len Brown, James Morris; +Cc: Stephen Rothwell, linux-acpi, linux-next, LKML On Thu, 06 May 2010 16:29:42 -0400 (EDT) Len Brown wrote: > > When CONFIG_PCI is not enabled: > > > > arch/x86/kernel/acpi/boot.c:1034: error: 'pci_bus_type' undeclared > > > > drivers/acpi/reboot.c:30: error:implicit declaration of function 'pci_find_bus' > > drivers/acpi/reboot.c:30: warning: assignment makes pointer from integer without a cast > > drivers/acpi/reboot.c:38: error:implicit declaration of function 'pci_bus_write_config_byte' > > CONFIG_ACPI depends on CONFIG_PCI, so this file should not be build with > CONFIG_PCI=n. > > Please let me know how you were able to generate this illegal > configuration. Same TPM kconfig that selects ACPI without any other qualifications. In 50 randconfig builds, 12 build failures were due to that one bad kconfig. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-05-06 23:38 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20100506151502.f97afe54.sfr@canb.auug.org.au>
2010-05-06 15:05 ` linux-next: Tree for May 6 (acpi: PM=n) Randy Dunlap
2010-05-06 20:26 ` [linux-pm] " Len Brown
2010-05-06 20:32 ` Randy Dunlap
2010-05-06 23:27 ` James Morris
2010-05-06 23:38 ` Randy Dunlap
2010-05-06 15:07 ` linux-next: Tree for May 6 (acpi: PCI=n) Randy Dunlap
2010-05-06 20:29 ` Len Brown
2010-05-06 20:42 ` Randy Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).