From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Len Brown <lenb@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [git pull request] ACPI patches for 2.6.34-rc6
Date: Sat, 8 May 2010 02:03:30 +0200 [thread overview]
Message-ID: <201005080203.30634.rjw@sisk.pl> (raw)
In-Reply-To: <alpine.LFD.2.00.1005071618410.901@i5.linux-foundation.org>
On Saturday 08 May 2010, Linus Torvalds wrote:
>
> On Sat, 8 May 2010, Rafael J. Wysocki wrote:
...
>
> Let me explain what I think we should do with actual code:
>
> acpi_enable();
> if (test_if_that_f_cking_bit_still_isnt_set)
> set_it_by_hand();
>
> wouldn't that work on your box?
Yes, it would.
> The acpi_enable() seems to work for you, so it wouldn't actually ever set it
> by hand.
>
> But the problem is that on a number of boxes, acpi_enable() apparently
> doesn't do what it should do. Because the stupid BIOS "knows" it is
> already in ACPI mode, but it forgot to actually set the bit!
To calrify, I think the approach in the Matthew's patch is correct, but since I have
some bad experience with that particular thing, I prefer to make that change in
2.6.35 and then move on to drop the flag entirely.
Rafael
next prev parent reply other threads:[~2010-05-08 0:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 2:22 [git pull request] ACPI patches for 2.6.34-rc6 Len Brown
2010-05-07 2:34 ` Linus Torvalds
2010-05-07 6:12 ` Matthew Garrett
2010-05-07 21:06 ` Linus Torvalds
2010-05-07 21:13 ` Matthew Garrett
2010-05-07 21:21 ` Linus Torvalds
2010-05-07 21:36 ` Matthew Garrett
2010-05-11 17:25 ` Matthew Garrett
2010-05-11 17:42 ` Linus Torvalds
2010-05-11 17:59 ` Matthew Garrett
2010-05-11 18:17 ` Linus Torvalds
2010-05-11 18:22 ` Matthew Garrett
2010-05-12 16:07 ` Robert Wörle
2010-05-12 16:12 ` Matthew Garrett
2010-05-07 22:39 ` Rafael J. Wysocki
2010-05-07 23:00 ` Linus Torvalds
2010-05-07 23:17 ` Rafael J. Wysocki
2010-05-07 23:21 ` Linus Torvalds
2010-05-08 0:03 ` Rafael J. Wysocki [this message]
2010-05-08 0:10 ` Linus Torvalds
2010-05-08 5:19 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005080203.30634.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox