From: Thomas Renninger <trenn@suse.de>
To: akpm@linux-foundation.org
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org, kamal@canonical.com,
bjorn.helgaas@hp.com, jkosina@suse.cz, rui.zhang@intel.com,
stable@kernel.org
Subject: Re: [patch for 2.6.34? 1/1] acpi: video: fix acpi_backlight=video
Date: Sat, 15 May 2010 15:29:26 +0200 [thread overview]
Message-ID: <201005151529.27170.trenn@suse.de> (raw)
In-Reply-To: <201005122233.o4CMXvi7024758@imap1.linux-foundation.org>
On Thursday 13 May 2010 12:33:57 am akpm@linux-foundation.org wrote:
> From: Kamal Mostafa <kamal@canonical.com>
>
> Make "acpi_backlight=video" param enable ACPI_VIDEO_BACKLIGHT_FORCE_VIDEO
> as intended, instead of incorrectly enabling video output switching.
IIRC the only native driver which takes over backlight switching is panasonic,
because Len saw 2 brightness steps missing.
This one should have been solved by a "compatibility" patch from Rui and
this one could also use video.ko by default.
Still, this one is a safe fix.
Just in case someone wants to avoid the use of this boot param and get
things done right by default (and likes to send a patch for it :)).
Thomas
> Addresses http://bugs.launchpad.net/bugs/573120
>
> Signed-off-by: Kamal Mostafa <kamal@canonical.com>
> Cc: Len Brown <lenb@kernel.org>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
> Cc: Jiri Kosina <jkosina@suse.cz>
> Cc: <stable@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/acpi/video_detect.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/acpi/video_detect.c~acpi-video-fix-acpi_backlight=video
> drivers/acpi/video_detect.c ---
> a/drivers/acpi/video_detect.c~acpi-video-fix-acpi_backlight=video +++
> a/drivers/acpi/video_detect.c
> @@ -250,7 +250,7 @@ static int __init acpi_backlight(char *s
> ACPI_VIDEO_BACKLIGHT_FORCE_VENDOR;
> if (!strcmp("video", str))
> acpi_video_support |=
> - ACPI_VIDEO_OUTPUT_SWITCHING_FORCE_VIDEO;
> + ACPI_VIDEO_BACKLIGHT_FORCE_VIDEO;
> }
> return 1;
> }
> _
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-05-15 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 22:33 [patch for 2.6.34? 1/1] acpi: video: fix acpi_backlight=video akpm
2010-05-14 13:34 ` Thomas Renninger
2010-05-15 13:29 ` Thomas Renninger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005151529.27170.trenn@suse.de \
--to=trenn@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=jkosina@suse.cz \
--cc=kamal@canonical.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox