public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org, kamal@canonical.com,
	bjorn.helgaas@hp.com, jkosina@suse.cz, rui.zhang@intel.com,
	stable@kernel.org, trenn@suse.de
Subject: Re: [patch for 2.6.35? 1/1] acpi: video: fix acpi_backlight=video
Date: Mon, 24 May 2010 18:22:59 -0400	[thread overview]
Message-ID: <20100524182259.9cc66230.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1005242053140.4059@localhost.localdomain>

On Mon, 24 May 2010 20:53:51 -0400 (EDT) Len Brown <lenb@kernel.org> wrote:

> 
> On Mon, 24 May 2010, akpm@linux-foundation.org wrote:
> 
> > From: Kamal Mostafa <kamal@canonical.com>
> > 
> > Make "acpi_backlight=video" param enable ACPI_VIDEO_BACKLIGHT_FORCE_VIDEO
> > as intended, instead of incorrectly enabling video output switching.
> > 
> > Addresses http://bugs.launchpad.net/bugs/573120
> > 
> > Signed-off-by: Kamal Mostafa <kamal@canonical.com>
> > Cc: Len Brown <lenb@kernel.org>
> > Cc: Zhang Rui <rui.zhang@intel.com>
> > Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
> > Cc: Jiri Kosina <jkosina@suse.cz>
> > Acked-by: Thomas Renninger <trenn@suse.de>
> > Cc: Thomas Renninger <trenn@suse.de>
> > Cc: <stable@kernel.org>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > ---
> > 
> >  drivers/acpi/video_detect.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff -puN drivers/acpi/video_detect.c~acpi-video-fix-acpi_backlight=video drivers/acpi/video_detect.c
> > --- a/drivers/acpi/video_detect.c~acpi-video-fix-acpi_backlight=video
> > +++ a/drivers/acpi/video_detect.c
> > @@ -266,7 +266,7 @@ static int __init acpi_display_output(ch
> >  				ACPI_VIDEO_OUTPUT_SWITCHING_FORCE_VENDOR;
> >  		if (!strcmp("video", str))
> >  			acpi_video_support |=
> > -				ACPI_VIDEO_OUTPUT_SWITCHING_FORCE_VIDEO;
> > +				ACPI_VIDEO_BACKLIGHT_FORCE_VIDEO;
> >  	}
> >  	return 1;
> >  }
>
> yes, it is in acpi-test and linux-next, do you pull those into mm still?
> 

(top-posting repaired!)

linux-next changes acpi_backlight().  In my tree patch(1) decided to
migrate the hunk into acpi_display_output().

Please check that acpi_display_output() didn't need the same change.

I'll drop the patch, thanks.

  reply	other threads:[~2010-05-25  1:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-24 19:10 [patch for 2.6.35? 1/1] acpi: video: fix acpi_backlight=video akpm
2010-05-25  0:53 ` Len Brown
2010-05-24 22:22   ` Andrew Morton [this message]
2010-05-28 20:15     ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100524182259.9cc66230.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=bjorn.helgaas@hp.com \
    --cc=jkosina@suse.cz \
    --cc=kamal@canonical.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=stable@kernel.org \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox