From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [Intel-gfx] [RFC PATCH 0/2] i915 brightness control Date: Thu, 3 Jun 2010 15:19:41 +0100 Message-ID: <20100603141941.GB768@srcf.ucam.org> References: <1275516702-27090-1-git-send-email-kamal@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:44601 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754363Ab0FCOTr (ORCPT ); Thu, 3 Jun 2010 10:19:47 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Pedro Ribeiro Cc: Kamal Mostafa , linux-acpi@vger.kernel.org, intel-gfx@lists.freedesktop.org On Thu, Jun 03, 2010 at 12:20:39AM +0100, Pedro Ribeiro wrote: > Are you sure this is a good idea to enable it by default just because > of a problem with one manufacturer (Dell)? It should (a-ha ha) be entirely safe on systems using the IGD opregion spec. > My Lenovo laptop has fine brightness control with a GM45 and this may break it. > Might be safer only to enable it for laptops with known problems. You have a complete list of all laptops with problems in this area? The ongoing situation with Windows 7 compatibility breaking machines that previously worked suggests that there's something going on which we don't understand or implement. -- Matthew Garrett | mjg59@srcf.ucam.org