From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Pavel Machek <pavel@ucw.cz>,
Maxim Levitsky <maximlevitsky@gmail.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
linux-pm <linux-pm@lists.linux-foundation.org>
Subject: Re: [linux-pm] [PATCH 1/2] suspend: Move NVS save/restore code to generic suspend functionality
Date: Fri, 11 Jun 2010 14:41:26 +0100 [thread overview]
Message-ID: <20100611134126.GA542@srcf.ucam.org> (raw)
In-Reply-To: <20100611133219.GD28084@khazad-dum.debian.net>
On Fri, Jun 11, 2010 at 10:32:19AM -0300, Henrique de Moraes Holschuh wrote:
> On Thu, 10 Jun 2010, Matthew Garrett wrote:
> > On Thu, Jun 10, 2010 at 03:58:16PM +0200, Pavel Machek wrote:
> > > Well... should we only do it in 'platform' hibernation mode? There are
> > > machines that predate windows/acpi and still should hibernate.
> >
> > If they predate acpi then they won't declare any NVS regions.
>
> What if they're ACPI and APM capable, and in APM mode? Would the code need
> to guard against that?
I can't imagine any case where that would cause problems, but if it does
then it's an easy fix.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-06-11 13:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 18:19 [PATCH] Store BIOS NVS area over s2ram [V2] Maxim Levitsky
2010-06-01 18:22 ` [PATCH 1/2] suspend: Move NVS save/restore code to generic suspend functionality Maxim Levitsky
2010-06-01 21:31 ` Rafael J. Wysocki
2010-06-01 21:52 ` Maxim Levitsky
2010-06-01 22:40 ` Rafael J. Wysocki
2010-06-01 22:46 ` Maxim Levitsky
2010-06-01 23:34 ` Rafael J. Wysocki
2010-06-10 13:58 ` [linux-pm] " Pavel Machek
2010-06-10 14:09 ` Matthew Garrett
2010-06-11 13:32 ` Henrique de Moraes Holschuh
2010-06-11 13:41 ` Matthew Garrett [this message]
2010-06-01 18:22 ` [PATCH 2/2] ACPI: Store NVS state even when entering suspend to RAM Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100611134126.GA542@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=hmh@hmh.eng.br \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=maximlevitsky@gmail.com \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).