From: Alex Chiang <achiang@canonical.com>
To: Jan Pogadl <pogadl.jan@googlemail.com>
Cc: linux-acpi@vger.kernel.org
Subject: Re: [BUG, REGRESSION] ACPI: Set _PDC
Date: Wed, 16 Jun 2010 21:24:14 -0600 [thread overview]
Message-ID: <20100617032413.GC2138@canonical.com> (raw)
In-Reply-To: <201006170040.24736.pogadl.jan@googlemail.com>
Hi Jan,
* Jan Pogadl <pogadl.jan@googlemail.com>:
> Hi,
>
> with commit commit 5d554a7bb0643a6151a84319bfeba8270bf5269e (ACPI: processor:
> add internal processor_physically_present()) a new function got introduced which
> always fails on machines with CONFIG_SMP disabled. Thus _PDC will never be
> initialized? set?.
My apologies for the regression and the slow response. Please
note my new email address.
Does this patch fix it?
---
diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
index 5128435..bcf0cf8 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -223,7 +223,7 @@ static bool processor_physically_present(acpi_handle handle)
type = (acpi_type == ACPI_TYPE_DEVICE) ? 1 : 0;
cpuid = acpi_get_cpuid(handle, type, acpi_id);
- if (cpuid == -1)
+ if ((cpuid == -1) && (num_online_cpus() > 1))
return false;
return true;
next prev parent reply other threads:[~2010-06-17 3:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 22:40 [BUG, REGRESSION] ACPI: Set _PDC Jan Pogadl
2010-06-17 3:24 ` Alex Chiang [this message]
2010-06-17 7:51 ` Jan Pogadl
2010-06-17 7:56 ` Chen Gong
2010-06-17 14:54 ` Alex Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100617032413.GC2138@canonical.com \
--to=achiang@canonical.com \
--cc=linux-acpi@vger.kernel.org \
--cc=pogadl.jan@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox