From: Alex Chiang <achiang@canonical.com>
To: Chen Gong <gong.chen@linux.intel.com>
Cc: Jan Pogadl <pogadl.jan@googlemail.com>, linux-acpi@vger.kernel.org
Subject: Re: [BUG, REGRESSION] ACPI: Set _PDC
Date: Thu, 17 Jun 2010 08:54:46 -0600 [thread overview]
Message-ID: <20100617145445.GE2138@canonical.com> (raw)
In-Reply-To: <4C19D51B.90100@linux.intel.com>
* Chen Gong <gong.chen@linux.intel.com>:
> >On Thursday 17 June 2010 05:24:14 Alex Chiang wrote:
> >>diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
> >>index 5128435..bcf0cf8 100644
> >>--- a/drivers/acpi/processor_core.c
> >>+++ b/drivers/acpi/processor_core.c
> >>@@ -223,7 +223,7 @@ static bool processor_physically_present(acpi_handle handle)
> >> type = (acpi_type == ACPI_TYPE_DEVICE) ? 1 : 0;
> >> cpuid = acpi_get_cpuid(handle, type, acpi_id);
> >>
> >>- if (cpuid == -1)
> >>+ if ((cpuid == -1)&& (num_online_cpus()> 1))
> >> return false;
> >>
> >> return true;
> >>
> I have a puzzle why num_online_cpus is used here, instead of
> num_possible_cpus. It will be possible under a hotplug scenario.
Hm, you're probably right.
I was following the example of the other usage of
acpi_get_cpuid() in acpi_processor_get_info(), but based on your
observation, it's probably better to use num_possible_cpus.
I'll change it when I submit a proper patch.
Thanks for the review.
/ac
prev parent reply other threads:[~2010-06-17 14:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 22:40 [BUG, REGRESSION] ACPI: Set _PDC Jan Pogadl
2010-06-17 3:24 ` Alex Chiang
2010-06-17 7:51 ` Jan Pogadl
2010-06-17 7:56 ` Chen Gong
2010-06-17 14:54 ` Alex Chiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100617145445.GE2138@canonical.com \
--to=achiang@canonical.com \
--cc=gong.chen@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=pogadl.jan@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox