From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Len Brown <lenb@kernel.org>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Len Brown <len.brown@intel.com>,
linux-pm@lists.linux-foundation.org,
Lin Ming <ming.m.lin@intel.com>,
"Moore, Robert" <robert.moore@intel.com>
Subject: [Resend][PATCH 4/4] ACPI / ACPICA: Fail acpi_gpe_wakeup() if ACPI_GPE_CAN_WAKE is unset
Date: Thu, 8 Jul 2010 00:45:34 +0200 [thread overview]
Message-ID: <201007080045.34877.rjw@sisk.pl> (raw)
In-Reply-To: <201007080041.38627.rjw@sisk.pl>
From: Rafael J. Wysocki <rjw@sisk.pl>
Make acpi_gpe_wakeup() return error code for GPEs whose
ACPI_GPE_CAN_WAKE flag is not set. This way acpi_gpe_wakeup() will
only wake for the GPEs reported by the host OS as "wakeup" ones with
the help of acpi_gpe_can_wake().
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/acpi/acpica/evxfevnt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/drivers/acpi/acpica/evxfevnt.c
===================================================================
--- linux-2.6.orig/drivers/acpi/acpica/evxfevnt.c
+++ linux-2.6/drivers/acpi/acpica/evxfevnt.c
@@ -239,7 +239,7 @@ acpi_status acpi_gpe_wakeup(acpi_handle
/* Ensure that we have a valid GPE number */
gpe_event_info = acpi_ev_get_gpe_event_info(gpe_device, gpe_number);
- if (!gpe_event_info) {
+ if (!gpe_event_info || !(gpe_event_info->flags & ACPI_GPE_CAN_WAKE)) {
status = AE_BAD_PARAMETER;
goto unlock_and_exit;
}
next prev parent reply other threads:[~2010-07-07 22:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 22:41 [Resend][PATCH 0/4] ACPI: Avoid executing _PRW twice for all devices Rafael J. Wysocki
2010-07-07 22:42 ` [Resend][PATCH 1/4] ACPI: Fix bogus GPE test in acpi_bus_set_run_wake_flags() Rafael J. Wysocki
2010-07-07 22:43 ` [Resend][PATCH 2/4] ACPI / ACPICA: Do not execute _PRW methods during initialization Rafael J. Wysocki
2010-07-07 22:44 ` [Resend][PATCH 3/4] ACPI / ACPICA: Simplify acpi_ev_initialize_gpe_block() Rafael J. Wysocki
2010-07-07 22:45 ` Rafael J. Wysocki [this message]
2010-07-12 18:37 ` [Resend][PATCH 0/4] ACPI: Avoid executing _PRW twice for all devices Len Brown
2010-07-12 19:35 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007080045.34877.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=ming.m.lin@intel.com \
--cc=mjg59@srcf.ucam.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox