From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 1/6] ACPI: Provide /sys/devices/system/ec/ Date: Fri, 9 Jul 2010 12:18:58 -0700 Message-ID: <20100709191858.GC8989@kroah.com> References: <1277996570-2686-1-git-send-email-trenn@suse.de> <1277996570-2686-2-git-send-email-trenn@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1277996570-2686-2-git-send-email-trenn@suse.de> Sender: platform-driver-x86-owner@vger.kernel.org To: Thomas Renninger Cc: lenb@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org, astarikovskiy@suse.de, Bjorn Helgaas List-Id: linux-acpi@vger.kernel.org On Thu, Jul 01, 2010 at 05:02:45PM +0200, Thomas Renninger wrote: > +config ACPI_EC_SYSFS > + tristate "EC read/write access through sysfs" > + default y > + help > + Say N to disable Embedded Controller /sys interface > + > + An Embedded Controller typically is available on laptops and reads > + sensor values like battery state and temperature. > + The kernel access the EC through ACPI parsed code provided by BIOS > + tables. > + Thus this option is a debug option that helps to write ACPI drivers > + and which can be used to identify ACPI code or EC firmware bugs. Wait, why is this a sysfs file at all? It should be a debugfs one, right? thanks, greg k-h