From: Thomas Renninger <trenn@suse.de>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: mjg59@srcf.ucam.org, platform-driver-x86@vger.kernel.org,
linux-acpi@vger.kernel.org, astarikovskiy@suse.de
Subject: Re: [PATCH] acpi ec_sys: Be more cautious about ec write access
Date: Sun, 1 Aug 2010 02:13:55 +0200 [thread overview]
Message-ID: <201008010213.56501.trenn@suse.de> (raw)
In-Reply-To: <20100730163717.GB32120@khazad-dum.debian.net>
On Friday 30 July 2010 06:37:17 pm Henrique de Moraes Holschuh wrote:
> On Thu, 29 Jul 2010, Thomas Renninger wrote:
> > - Only allow root to read/write io file (sever bug!)
>
> I'd go further, and only allow CAP_SYS_RAWIO.
I'll have a look and eventually come up with something on-top.
> > + The kernel accesses the EC through ACPI parsed code provided by BIOS
> > + tables. This option allows to access the EC directly without ACPI
> > + code being involved.
>
> This is not really true. Kernel drivers can, and do access the EC without
> help from the AML firmware (DSDT, SSDT...).
Yes, the native laptop driver hacks which should not exist...
Generally the EC should only be accessed via ACPI interpreted code, is it
really worth to mention these exceptions at this point?
Thomas
next prev parent reply other threads:[~2010-08-01 0:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 20:08 ACPI ec.c and ec_sys.c fixes Thomas Renninger
2010-07-29 20:08 ` [PATCH 1/2] acpi ec: Fix possible double io port registration Thomas Renninger
2010-07-29 20:08 ` [PATCH 2/2] acpi ec_sys: Be more cautious about ec write access Thomas Renninger
2010-07-29 20:16 ` Thomas Renninger
2010-07-29 20:30 ` [PATCH] " Thomas Renninger
2010-07-30 16:37 ` Henrique de Moraes Holschuh
2010-08-01 0:13 ` Thomas Renninger [this message]
2010-08-01 14:15 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008010213.56501.trenn@suse.de \
--to=trenn@suse.de \
--cc=astarikovskiy@suse.de \
--cc=hmh@hmh.eng.br \
--cc=linux-acpi@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox