From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Zhang Rui <rui.zhang@intel.com>
Cc: "Brown, Len" <lenb@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"Moore, Robert" <robert.moore@intel.com>,
Thomas Renninger <trenn@suse.de>
Subject: Re: [PATCH] ACPI video: fix a poor error message
Date: Tue, 17 Aug 2010 14:34:58 +0100 [thread overview]
Message-ID: <20100817133458.GA22699@srcf.ucam.org> (raw)
In-Reply-To: <1282012975.5181.16.camel@rui>
On Tue, Aug 17, 2010 at 10:42:55AM +0800, Zhang Rui wrote:
> *cap |= ACPI_VIDEO_BACKLIGHT;
> if (ACPI_FAILURE(acpi_get_handle(handle, "_BQC", &h_dummy)))
> - printk(KERN_WARNING FW_BUG PREFIX "ACPI brightness "
> - "control misses _BQC function\n");
> + printk(KERN_WARNING FW_BUG PREFIX "could not find "
> + "required _BQC function\n");
I don't really like the "required". It's a spec requirement but the
driver will work fine (if suboptimally) without it.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-08-17 13:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 2:42 [PATCH] ACPI video: fix a poor error message Zhang Rui
2010-08-17 13:34 ` Matthew Garrett [this message]
2010-08-17 15:24 ` Moore, Robert
2010-08-17 15:27 ` Matthew Garrett
2010-08-17 15:46 ` Moore, Robert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100817133458.GA22699@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=robert.moore@intel.com \
--cc=rui.zhang@intel.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox