From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Huang Ying <ying.huang@intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: acpi_atomic_read() requirements
Date: Fri, 3 Sep 2010 09:00:33 -0600 [thread overview]
Message-ID: <201009030900.33581.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <20100903111705.3ae78159@basil.nowhere.org>
On Friday, September 03, 2010 03:17:05 am Andi Kleen wrote:
> > Good. Unless there's a spec requirement for 64-bit accesses in this
> > area, I think it's better to do it the same way as acpi_read(), just
> > so we're as consistent as possible.
>
> I'm not sure if the spec explicit asks for it, but doing a full
> 64bit access would be in the spirit of it at least.
It would, and I hoped the spec would clarify that, but I didn't
see anything.
If there's a reason to have acpi_atomic_read() work differently
than acpi_read() in this respect, that's fine. I just don't see
it yet. If they *can* be made similar in this, I think we might
be able to collapse them into a single, smaller implementation.
> On the other hand I would expect hardware that really requires 64bit
> to be rare because 32bit OS would always have some trouble with
> it.
prev parent reply other threads:[~2010-09-03 15:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-03 1:34 acpi_atomic_read() requirements Bjorn Helgaas
2010-09-03 1:49 ` Huang Ying
2010-09-03 4:32 ` Bjorn Helgaas
2010-09-03 9:17 ` Andi Kleen
2010-09-03 15:00 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009030900.33581.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=andi@firstfloor.org \
--cc=linux-acpi@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox