* [PATCH 02/16] PM / ACPI: Blacklist systems known to require acpi_sleep=nonvs
2010-09-29 3:44 ` [PATCH 01/16] ACPI: Don't report current_now if battery reports in mWh Len Brown
@ 2010-09-29 3:44 ` Len Brown
2010-09-29 3:44 ` [PATCH 03/16] ACPI: enable repeated PCIEXP wakeup by clearing PCIEXP_WAKE_STS on resume Len Brown
` (13 subsequent siblings)
14 siblings, 0 replies; 27+ messages in thread
From: Len Brown @ 2010-09-29 3:44 UTC (permalink / raw)
To: linux-acpi; +Cc: Rafael J. Wysocki, Len Brown
From: Rafael J. Wysocki <rjw@sisk.pl>
Commit 2a6b69765ad794389f2fc3e14a0afa1a995221c2 (ACPI: Store NVS
state even when entering suspend to RAM) changed the ACPI suspend
to RAM code so that the NVS memory area is always unconditionally
saved during suspend and restored during resume, since some systems
evidently need that for the suspend-resume to work on them. However,
it turned out that this change broke suspend-resume on a few systems,
so commit 72ad5d77fb981963edae15eee8196c80238f5ed0 (ACPI / Sleep:
Allow the NVS saving to be skipped during suspend to RAM) introduced
the acpi_sleep=nonvs command line switch to allow their users to
work around this issue. To keep track of the systems that require
this workaround and to make the life of their users slightly easier
blacklist them in acpisleep_dmi_table[].
https://bugzilla.kernel.org/show_bug.cgi?id=16396
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/sleep.c | 22 ++++++++++++++++++++++
1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
index cf82989..4754ff6 100644
--- a/drivers/acpi/sleep.c
+++ b/drivers/acpi/sleep.c
@@ -363,6 +363,12 @@ static int __init init_old_suspend_ordering(const struct dmi_system_id *d)
return 0;
}
+static int __init init_nvs_nosave(const struct dmi_system_id *d)
+{
+ acpi_nvs_nosave();
+ return 0;
+}
+
static struct dmi_system_id __initdata acpisleep_dmi_table[] = {
{
.callback = init_old_suspend_ordering,
@@ -397,6 +403,22 @@ static struct dmi_system_id __initdata acpisleep_dmi_table[] = {
DMI_MATCH(DMI_BOARD_NAME, "CF51-2L"),
},
},
+ {
+ .callback = init_nvs_nosave,
+ .ident = "Sony Vaio VGN-SR11M",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "VGN-SR11M"),
+ },
+ },
+ {
+ .callback = init_nvs_nosave,
+ .ident = "Everex StepNote Series",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Everex Systems, Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Everex StepNote Series"),
+ },
+ },
{},
};
#endif /* CONFIG_SUSPEND */
--
1.7.3.2.g9027fa
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 03/16] ACPI: enable repeated PCIEXP wakeup by clearing PCIEXP_WAKE_STS on resume
2010-09-29 3:44 ` [PATCH 01/16] ACPI: Don't report current_now if battery reports in mWh Len Brown
2010-09-29 3:44 ` [PATCH 02/16] PM / ACPI: Blacklist systems known to require acpi_sleep=nonvs Len Brown
@ 2010-09-29 3:44 ` Len Brown
2010-09-29 3:44 ` [PATCH 04/16] ACPI: delete ZEPTO idle=nomwait DMI quirk Len Brown
` (12 subsequent siblings)
14 siblings, 0 replies; 27+ messages in thread
From: Len Brown @ 2010-09-29 3:44 UTC (permalink / raw)
To: linux-acpi; +Cc: Colin Ian King, Len Brown
From: Colin Ian King <colin.king@canonical.com>
Section 4.7.3.1.1 (PM1 Status Registers) of version 4.0 of
the ACPI spec concerning PCIEXP_WAKE_STS points out in
in the final note field in table 4-11 that if this bit is
set to 1 and the system is put into a sleeping state then
the system will not automatically wake.
This bit gets set by hardware to indicate that the system
woke up due to a PCI Express wakeup event, so clear it during
acpi_hw_clear_acpi_status() calls to enable subsequent
resumes to work.
BugLink: http://bugs.launchpad.net/bugs/613381
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/acpica/aclocal.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/acpica/aclocal.h b/drivers/acpi/acpica/aclocal.h
index df85b53..7dad916 100644
--- a/drivers/acpi/acpica/aclocal.h
+++ b/drivers/acpi/acpica/aclocal.h
@@ -854,6 +854,7 @@ struct acpi_bit_register_info {
ACPI_BITMASK_POWER_BUTTON_STATUS | \
ACPI_BITMASK_SLEEP_BUTTON_STATUS | \
ACPI_BITMASK_RT_CLOCK_STATUS | \
+ ACPI_BITMASK_PCIEXP_WAKE_DISABLE | \
ACPI_BITMASK_WAKE_STATUS)
#define ACPI_BITMASK_TIMER_ENABLE 0x0001
--
1.7.3.2.g9027fa
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 04/16] ACPI: delete ZEPTO idle=nomwait DMI quirk
2010-09-29 3:44 ` [PATCH 01/16] ACPI: Don't report current_now if battery reports in mWh Len Brown
2010-09-29 3:44 ` [PATCH 02/16] PM / ACPI: Blacklist systems known to require acpi_sleep=nonvs Len Brown
2010-09-29 3:44 ` [PATCH 03/16] ACPI: enable repeated PCIEXP wakeup by clearing PCIEXP_WAKE_STS on resume Len Brown
@ 2010-09-29 3:44 ` Len Brown
2010-09-29 3:44 ` [PATCH 05/16] ACPI: expand Vista blacklist to include SP1 and SP2 Len Brown
` (11 subsequent siblings)
14 siblings, 0 replies; 27+ messages in thread
From: Len Brown @ 2010-09-29 3:44 UTC (permalink / raw)
To: linux-acpi; +Cc: Len Brown
From: Len Brown <len.brown@intel.com>
per comments in the bug report, this entry
seems to hurt at much as it helps.
https://bugzilla.kernel.org/show_bug.cgi?id=10807
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/processor_core.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
index e9699aa..b618f88 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -29,12 +29,6 @@ static int set_no_mwait(const struct dmi_system_id *id)
static struct dmi_system_id __cpuinitdata processor_idle_dmi_table[] = {
{
- set_no_mwait, "IFL91 board", {
- DMI_MATCH(DMI_BIOS_VENDOR, "COMPAL"),
- DMI_MATCH(DMI_SYS_VENDOR, "ZEPTO"),
- DMI_MATCH(DMI_PRODUCT_VERSION, "3215W"),
- DMI_MATCH(DMI_BOARD_NAME, "IFL91") }, NULL},
- {
set_no_mwait, "Extensa 5220", {
DMI_MATCH(DMI_BIOS_VENDOR, "Phoenix Technologies LTD"),
DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
--
1.7.3.2.g9027fa
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 05/16] ACPI: expand Vista blacklist to include SP1 and SP2
2010-09-29 3:44 ` [PATCH 01/16] ACPI: Don't report current_now if battery reports in mWh Len Brown
` (2 preceding siblings ...)
2010-09-29 3:44 ` [PATCH 04/16] ACPI: delete ZEPTO idle=nomwait DMI quirk Len Brown
@ 2010-09-29 3:44 ` Len Brown
2010-09-29 3:44 ` [PATCH 06/16] ACPI: EC: add Vista incompatibility DMI entry for Toshiba Satellite L355 Len Brown
` (10 subsequent siblings)
14 siblings, 0 replies; 27+ messages in thread
From: Len Brown @ 2010-09-29 3:44 UTC (permalink / raw)
To: linux-acpi; +Cc: Len Brown
From: Len Brown <len.brown@intel.com>
When we claim incompatibility with Vista,
include both Vista SP1 and SP2.
https://bugzilla.kernel.org/show_bug.cgi?id=12641
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/blacklist.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
index 2bb28b9..3eda6c0 100644
--- a/drivers/acpi/blacklist.c
+++ b/drivers/acpi/blacklist.c
@@ -183,6 +183,8 @@ static int __init dmi_disable_osi_vista(const struct dmi_system_id *d)
{
printk(KERN_NOTICE PREFIX "DMI detected: %s\n", d->ident);
acpi_osi_setup("!Windows 2006");
+ acpi_osi_setup("!Windows 2006 SP1");
+ acpi_osi_setup("!Windows 2006 SP2");
return 0;
}
static int __init dmi_disable_osi_win7(const struct dmi_system_id *d)
--
1.7.3.2.g9027fa
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 06/16] ACPI: EC: add Vista incompatibility DMI entry for Toshiba Satellite L355
2010-09-29 3:44 ` [PATCH 01/16] ACPI: Don't report current_now if battery reports in mWh Len Brown
` (3 preceding siblings ...)
2010-09-29 3:44 ` [PATCH 05/16] ACPI: expand Vista blacklist to include SP1 and SP2 Len Brown
@ 2010-09-29 3:44 ` Len Brown
2010-09-29 3:44 ` [PATCH 07/16] ACPI: fix build warnings resulting from merge window conflict Len Brown
` (9 subsequent siblings)
14 siblings, 0 replies; 27+ messages in thread
From: Len Brown @ 2010-09-29 3:44 UTC (permalink / raw)
To: linux-acpi; +Cc: Len Brown
From: Len Brown <len.brown@intel.com>
https://bugzilla.kernel.org/show_bug.cgi?id=12641
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/blacklist.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
index 3eda6c0..571a003 100644
--- a/drivers/acpi/blacklist.c
+++ b/drivers/acpi/blacklist.c
@@ -228,6 +228,14 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
},
},
{
+ .callback = dmi_disable_osi_vista,
+ .ident = "Toshiba Satellite L355",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "Satellite L355"),
+ },
+ },
+ {
.callback = dmi_disable_osi_win7,
.ident = "ASUS K50IJ",
.matches = {
--
1.7.3.2.g9027fa
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 07/16] ACPI: fix build warnings resulting from merge window conflict
2010-09-29 3:44 ` [PATCH 01/16] ACPI: Don't report current_now if battery reports in mWh Len Brown
` (4 preceding siblings ...)
2010-09-29 3:44 ` [PATCH 06/16] ACPI: EC: add Vista incompatibility DMI entry for Toshiba Satellite L355 Len Brown
@ 2010-09-29 3:44 ` Len Brown
2010-09-29 3:44 ` [PATCH 08/16] ACPI video: fix a poor warning message Len Brown
` (8 subsequent siblings)
14 siblings, 0 replies; 27+ messages in thread
From: Len Brown @ 2010-09-29 3:44 UTC (permalink / raw)
To: linux-acpi; +Cc: Zhang Rui, Len Brown
From: Zhang Rui <rui.zhang@intel.com>
drivers/acpi/sysfs.c:154: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
Introduced by commit 1c8fce27e275fd7c6b75bc6455745f02d3903ee6 ("ACPI:
introduce drivers/acpi/sysfs.c") interacting with commit
9bbb9e5a33109b2832e2e63dcc7a132924ab374b ("param: use ops in struct
kernel_param, rather than get and set fns directly").
Use module_param_cb instead of the obsoleted module_param_call to fix a build warning.
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/sysfs.c | 20 ++++++++++++++------
1 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c
index 68e2e45..f8588f8 100644
--- a/drivers/acpi/sysfs.c
+++ b/drivers/acpi/sysfs.c
@@ -100,7 +100,7 @@ static const struct acpi_dlevel acpi_debug_levels[] = {
ACPI_DEBUG_INIT(ACPI_LV_EVENTS),
};
-static int param_get_debug_layer(char *buffer, struct kernel_param *kp)
+static int param_get_debug_layer(char *buffer, const struct kernel_param *kp)
{
int result = 0;
int i;
@@ -128,7 +128,7 @@ static int param_get_debug_layer(char *buffer, struct kernel_param *kp)
return result;
}
-static int param_get_debug_level(char *buffer, struct kernel_param *kp)
+static int param_get_debug_level(char *buffer, const struct kernel_param *kp)
{
int result = 0;
int i;
@@ -149,10 +149,18 @@ static int param_get_debug_level(char *buffer, struct kernel_param *kp)
return result;
}
-module_param_call(debug_layer, param_set_uint, param_get_debug_layer,
- &acpi_dbg_layer, 0644);
-module_param_call(debug_level, param_set_uint, param_get_debug_level,
- &acpi_dbg_level, 0644);
+static struct kernel_param_ops param_ops_debug_layer = {
+ .set = param_set_uint,
+ .get = param_get_debug_layer,
+};
+
+static struct kernel_param_ops param_ops_debug_level = {
+ .set = param_set_uint,
+ .get = param_get_debug_level,
+};
+
+module_param_cb(debug_layer, ¶m_ops_debug_layer, &acpi_dbg_layer, 0644);
+module_param_cb(debug_level, ¶m_ops_debug_level, &acpi_dbg_level, 0644);
static char trace_method_name[6];
module_param_string(trace_method_name, trace_method_name, 6, 0644);
--
1.7.3.2.g9027fa
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 08/16] ACPI video: fix a poor warning message
2010-09-29 3:44 ` [PATCH 01/16] ACPI: Don't report current_now if battery reports in mWh Len Brown
` (5 preceding siblings ...)
2010-09-29 3:44 ` [PATCH 07/16] ACPI: fix build warnings resulting from merge window conflict Len Brown
@ 2010-09-29 3:44 ` Len Brown
2010-09-29 3:44 ` [PATCH 09/16] ACPI: Fix typos Len Brown
` (7 subsequent siblings)
14 siblings, 0 replies; 27+ messages in thread
From: Len Brown @ 2010-09-29 3:44 UTC (permalink / raw)
To: linux-acpi; +Cc: Zhang Rui, Len Brown
From: Zhang Rui <rui.zhang@intel.com>
Fix a vague warning message.
https://bugzilla.kernel.org/show_bug.cgi?id=16599
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/video_detect.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index c5fef01..b836761 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -59,8 +59,8 @@ acpi_backlight_cap_match(acpi_handle handle, u32 level, void *context,
"support\n"));
*cap |= ACPI_VIDEO_BACKLIGHT;
if (ACPI_FAILURE(acpi_get_handle(handle, "_BQC", &h_dummy)))
- printk(KERN_WARNING FW_BUG PREFIX "ACPI brightness "
- "control misses _BQC function\n");
+ printk(KERN_WARNING FW_BUG PREFIX "No _BQC method, "
+ "cannot determine initial brightness\n");
/* We have backlight support, no need to scan further */
return AE_CTRL_TERMINATE;
}
--
1.7.3.2.g9027fa
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 09/16] ACPI: Fix typos
2010-09-29 3:44 ` [PATCH 01/16] ACPI: Don't report current_now if battery reports in mWh Len Brown
` (6 preceding siblings ...)
2010-09-29 3:44 ` [PATCH 08/16] ACPI video: fix a poor warning message Len Brown
@ 2010-09-29 3:44 ` Len Brown
2010-09-29 3:44 ` [PATCH 10/16] ACPI: add missing __percpu markup in arch/x86/kernel/acpi/cstate.c Len Brown
` (6 subsequent siblings)
14 siblings, 0 replies; 27+ messages in thread
From: Len Brown @ 2010-09-29 3:44 UTC (permalink / raw)
To: linux-acpi; +Cc: Lucas De Marchi, Len Brown
From: Lucas De Marchi <lucas.de.marchi@gmail.com>
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/acpica/exutils.c | 2 +-
drivers/acpi/acpica/rsutils.c | 2 +-
drivers/acpi/apei/Kconfig | 2 +-
drivers/acpi/apei/erst-dbg.c | 2 +-
drivers/acpi/apei/erst.c | 2 +-
drivers/acpi/bus.c | 4 ++--
drivers/acpi/processor_perflib.c | 4 ++--
include/acpi/acpixf.h | 2 +-
8 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/acpi/acpica/exutils.c b/drivers/acpi/acpica/exutils.c
index 74c24d5..4093522 100644
--- a/drivers/acpi/acpica/exutils.c
+++ b/drivers/acpi/acpica/exutils.c
@@ -109,7 +109,7 @@ void acpi_ex_enter_interpreter(void)
*
* DESCRIPTION: Reacquire the interpreter execution region from within the
* interpreter code. Failure to enter the interpreter region is a
- * fatal system error. Used in conjuction with
+ * fatal system error. Used in conjunction with
* relinquish_interpreter
*
******************************************************************************/
diff --git a/drivers/acpi/acpica/rsutils.c b/drivers/acpi/acpica/rsutils.c
index 22cfcfb..491191e 100644
--- a/drivers/acpi/acpica/rsutils.c
+++ b/drivers/acpi/acpica/rsutils.c
@@ -149,7 +149,7 @@ acpi_rs_move_data(void *destination, void *source, u16 item_count, u8 move_type)
/*
* 16-, 32-, and 64-bit cases must use the move macros that perform
- * endian conversion and/or accomodate hardware that cannot perform
+ * endian conversion and/or accommodate hardware that cannot perform
* misaligned memory transfers
*/
case ACPI_RSC_MOVE16:
diff --git a/drivers/acpi/apei/Kconfig b/drivers/acpi/apei/Kconfig
index 907e350..fca34cc 100644
--- a/drivers/acpi/apei/Kconfig
+++ b/drivers/acpi/apei/Kconfig
@@ -34,6 +34,6 @@ config ACPI_APEI_ERST_DEBUG
depends on ACPI_APEI
help
ERST is a way provided by APEI to save and retrieve hardware
- error infomation to and from a persistent store. Enable this
+ error information to and from a persistent store. Enable this
if you want to debugging and testing the ERST kernel support
and firmware implementation.
diff --git a/drivers/acpi/apei/erst-dbg.c b/drivers/acpi/apei/erst-dbg.c
index 5281ddd..98ffa29 100644
--- a/drivers/acpi/apei/erst-dbg.c
+++ b/drivers/acpi/apei/erst-dbg.c
@@ -2,7 +2,7 @@
* APEI Error Record Serialization Table debug support
*
* ERST is a way provided by APEI to save and retrieve hardware error
- * infomation to and from a persistent store. This file provide the
+ * information to and from a persistent store. This file provide the
* debugging/testing support for ERST kernel support and firmware
* implementation.
*
diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c
index 18645f4..a4904f1 100644
--- a/drivers/acpi/apei/erst.c
+++ b/drivers/acpi/apei/erst.c
@@ -2,7 +2,7 @@
* APEI Error Record Serialization Table support
*
* ERST is a way provided by APEI to save and retrieve hardware error
- * infomation to and from a persistent store.
+ * information to and from a persistent store.
*
* For more information about ERST, please refer to ACPI Specification
* version 4.0, section 17.4.
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 5c221ab..cc17b35 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -55,7 +55,7 @@ EXPORT_SYMBOL(acpi_root_dir);
static int set_power_nocheck(const struct dmi_system_id *id)
{
printk(KERN_NOTICE PREFIX "%s detected - "
- "disable power check in power transistion\n", id->ident);
+ "disable power check in power transition\n", id->ident);
acpi_power_nocheck = 1;
return 0;
}
@@ -1027,7 +1027,7 @@ static int __init acpi_init(void)
/*
* If the laptop falls into the DMI check table, the power state check
- * will be disabled in the course of device power transistion.
+ * will be disabled in the course of device power transition.
*/
dmi_check_system(power_nocheck_dmi_table);
diff --git a/drivers/acpi/processor_perflib.c b/drivers/acpi/processor_perflib.c
index ba1bd26..3a73a93 100644
--- a/drivers/acpi/processor_perflib.c
+++ b/drivers/acpi/processor_perflib.c
@@ -447,8 +447,8 @@ int acpi_processor_notify_smm(struct module *calling_module)
if (!try_module_get(calling_module))
return -EINVAL;
- /* is_done is set to negative if an error occured,
- * and to postitive if _no_ error occured, but SMM
+ /* is_done is set to negative if an error occurred,
+ * and to postitive if _no_ error occurred, but SMM
* was already notified. This avoids double notification
* which might lead to unexpected results...
*/
diff --git a/include/acpi/acpixf.h b/include/acpi/acpixf.h
index c0786d4..984cdc6 100644
--- a/include/acpi/acpixf.h
+++ b/include/acpi/acpixf.h
@@ -55,7 +55,7 @@
extern u8 acpi_gbl_permanent_mmap;
/*
- * Globals that are publically available, allowing for
+ * Globals that are publicly available, allowing for
* run time configuration
*/
extern u32 acpi_dbg_level;
--
1.7.3.2.g9027fa
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 10/16] ACPI: add missing __percpu markup in arch/x86/kernel/acpi/cstate.c
2010-09-29 3:44 ` [PATCH 01/16] ACPI: Don't report current_now if battery reports in mWh Len Brown
` (7 preceding siblings ...)
2010-09-29 3:44 ` [PATCH 09/16] ACPI: Fix typos Len Brown
@ 2010-09-29 3:44 ` Len Brown
2010-09-29 3:44 ` [PATCH 11/16] ACPI: Kconfig: fix typo Len Brown
` (5 subsequent siblings)
14 siblings, 0 replies; 27+ messages in thread
From: Len Brown @ 2010-09-29 3:44 UTC (permalink / raw)
To: linux-acpi; +Cc: Namhyung Kim, Len Brown
From: Namhyung Kim <namhyung@gmail.com>
cpu_cstate_entry is a percpu pointer
but was missing __percpu markup.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Len Brown <len.brown@intel.com>
---
arch/x86/kernel/acpi/cstate.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/acpi/cstate.c
index fb7a5f0..fb16f17 100644
--- a/arch/x86/kernel/acpi/cstate.c
+++ b/arch/x86/kernel/acpi/cstate.c
@@ -61,7 +61,7 @@ struct cstate_entry {
unsigned int ecx;
} states[ACPI_PROCESSOR_MAX_POWER];
};
-static struct cstate_entry *cpu_cstate_entry; /* per CPU ptr */
+static struct cstate_entry __percpu *cpu_cstate_entry; /* per CPU ptr */
static short mwait_supported[ACPI_PROCESSOR_MAX_POWER];
--
1.7.3.2.g9027fa
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 11/16] ACPI: Kconfig: fix typo.
2010-09-29 3:44 ` [PATCH 01/16] ACPI: Don't report current_now if battery reports in mWh Len Brown
` (8 preceding siblings ...)
2010-09-29 3:44 ` [PATCH 10/16] ACPI: add missing __percpu markup in arch/x86/kernel/acpi/cstate.c Len Brown
@ 2010-09-29 3:44 ` Len Brown
2010-09-29 3:44 ` [PATCH 12/16] ACPI: Fix the ERST build warning Len Brown
` (4 subsequent siblings)
14 siblings, 0 replies; 27+ messages in thread
From: Len Brown @ 2010-09-29 3:44 UTC (permalink / raw)
To: linux-acpi; +Cc: Andrea Gelmini, Len Brown
From: Andrea Gelmini <andrea.gelmini@gelma.net>
"power of" -> "power off"
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index b811f21..88681ac 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -105,7 +105,7 @@ config ACPI_EC_DEBUGFS
Be aware that using this interface can confuse your Embedded
Controller in a way that a normal reboot is not enough. You then
- have to power of your system, and remove the laptop battery for
+ have to power off your system, and remove the laptop battery for
some seconds.
An Embedded Controller typically is available on laptops and reads
sensor values like battery state and temperature.
--
1.7.3.2.g9027fa
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 12/16] ACPI: Fix the ERST build warning
2010-09-29 3:44 ` [PATCH 01/16] ACPI: Don't report current_now if battery reports in mWh Len Brown
` (9 preceding siblings ...)
2010-09-29 3:44 ` [PATCH 11/16] ACPI: Kconfig: fix typo Len Brown
@ 2010-09-29 3:44 ` Len Brown
2010-09-29 18:09 ` Len Brown
2010-09-29 3:44 ` [PATCH 13/16] ACPI: acpi_pad: simplify code to avoid false gcc " Len Brown
` (3 subsequent siblings)
14 siblings, 1 reply; 27+ messages in thread
From: Len Brown @ 2010-09-29 3:44 UTC (permalink / raw)
To: linux-acpi; +Cc: Alan Cox, Len Brown
From: Alan Cox <alan@linux.intel.com>
drivers/acpi/apei/erst.c:273: warning: cast to pointer from integer of different size
drivers/acpi/apei/erst.c:274: warning: cast to pointer from integer of different size
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/apei/erst.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c
index a4904f1..37d7a05 100644
--- a/drivers/acpi/apei/erst.c
+++ b/drivers/acpi/apei/erst.c
@@ -270,8 +270,8 @@ static int erst_exec_move_data(struct apei_exec_context *ctx,
rc = __apei_exec_read_register(entry, &offset);
if (rc)
return rc;
- memmove((void *)ctx->dst_base + offset,
- (void *)ctx->src_base + offset,
+ memmove((void *)(unsigned long)ctx->dst_base + offset,
+ (void *)(unsigned long)ctx->src_base + offset,
ctx->var2);
return 0;
--
1.7.3.2.g9027fa
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 13/16] ACPI: acpi_pad: simplify code to avoid false gcc build warning
2010-09-29 3:44 ` [PATCH 01/16] ACPI: Don't report current_now if battery reports in mWh Len Brown
` (10 preceding siblings ...)
2010-09-29 3:44 ` [PATCH 12/16] ACPI: Fix the ERST build warning Len Brown
@ 2010-09-29 3:44 ` Len Brown
2010-09-29 3:44 ` [PATCH 14/16] ACPI: fan: Fix more unbalanced code block Len Brown
` (2 subsequent siblings)
14 siblings, 0 replies; 27+ messages in thread
From: Len Brown @ 2010-09-29 3:44 UTC (permalink / raw)
To: linux-acpi; +Cc: Len Brown, Len Brown
From: Len Brown <len.brown@intel.com>
acpi_pad.c:432: warning: ‘num_cpus’ may be used uninitialized in this function
gcc 4.4.4 was unable to notice that num_cpus is always set.
Re-arrange the code to un-confuse gcc, and also make
it easier for humans to read....
Signed-off-by: Len Brown <len.browns@intel.com>
---
drivers/acpi/acpi_pad.c | 34 ++++++++++++++++++----------------
1 files changed, 18 insertions(+), 16 deletions(-)
diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c
index b76848c..6b115f6 100644
--- a/drivers/acpi/acpi_pad.c
+++ b/drivers/acpi/acpi_pad.c
@@ -382,31 +382,32 @@ static void acpi_pad_remove_sysfs(struct acpi_device *device)
device_remove_file(&device->dev, &dev_attr_rrtime);
}
-/* Query firmware how many CPUs should be idle */
-static int acpi_pad_pur(acpi_handle handle, int *num_cpus)
+/*
+ * Query firmware how many CPUs should be idle
+ * return -1 on failure
+ */
+static int acpi_pad_pur(acpi_handle handle)
{
struct acpi_buffer buffer = {ACPI_ALLOCATE_BUFFER, NULL};
union acpi_object *package;
- int rev, num, ret = -EINVAL;
+ int num = -1;
if (ACPI_FAILURE(acpi_evaluate_object(handle, "_PUR", NULL, &buffer)))
- return -EINVAL;
+ return num;
if (!buffer.length || !buffer.pointer)
- return -EINVAL;
+ return num;
package = buffer.pointer;
- if (package->type != ACPI_TYPE_PACKAGE || package->package.count != 2)
- goto out;
- rev = package->package.elements[0].integer.value;
- num = package->package.elements[1].integer.value;
- if (rev != 1 || num < 0)
- goto out;
- *num_cpus = num;
- ret = 0;
-out:
+
+ if (package->type == ACPI_TYPE_PACKAGE &&
+ package->package.count == 2 &&
+ package->package.elements[0].integer.value == 1) /* rev 1 */
+
+ num = package->package.elements[1].integer.value;
+
kfree(buffer.pointer);
- return ret;
+ return num;
}
/* Notify firmware how many CPUs are idle */
@@ -433,7 +434,8 @@ static void acpi_pad_handle_notify(acpi_handle handle)
uint32_t idle_cpus;
mutex_lock(&isolated_cpus_lock);
- if (acpi_pad_pur(handle, &num_cpus)) {
+ num_cpus = acpi_pad_pur(handle);
+ if (num_cpus < 0) {
mutex_unlock(&isolated_cpus_lock);
return;
}
--
1.7.3.2.g9027fa
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 14/16] ACPI: fan: Fix more unbalanced code block
2010-09-29 3:44 ` [PATCH 01/16] ACPI: Don't report current_now if battery reports in mWh Len Brown
` (11 preceding siblings ...)
2010-09-29 3:44 ` [PATCH 13/16] ACPI: acpi_pad: simplify code to avoid false gcc " Len Brown
@ 2010-09-29 3:44 ` Len Brown
2010-09-29 3:44 ` [PATCH 15/16] ACPI: Disable Windows Vista compatibility for Toshiba P305D Len Brown
2010-09-29 3:44 ` [PATCH 16/16] ACPI: add DMI entry to work around another insane Toshiba BIOS Len Brown
14 siblings, 0 replies; 27+ messages in thread
From: Len Brown @ 2010-09-29 3:44 UTC (permalink / raw)
To: linux-acpi; +Cc: Luis Henriques, Len Brown
From: Luis Henriques <luis.henrix@gmail.com>
commit 934231de706d2579fae14f5857fcd8de991009ff fixes an unbalanced
CONFIG_ACPI_PROCFS code block during module initialisation. This
patch fixes similar issue but for the module exit.
Signed-off-by: Luis Henriques <luis.henrix@gmail.com>
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/fan.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c
index 8a3b840..d94d295 100644
--- a/drivers/acpi/fan.c
+++ b/drivers/acpi/fan.c
@@ -369,7 +369,9 @@ static void __exit acpi_fan_exit(void)
acpi_bus_unregister_driver(&acpi_fan_driver);
+#ifdef CONFIG_ACPI_PROCFS
remove_proc_entry(ACPI_FAN_CLASS, acpi_root_dir);
+#endif
return;
}
--
1.7.3.2.g9027fa
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 15/16] ACPI: Disable Windows Vista compatibility for Toshiba P305D
2010-09-29 3:44 ` [PATCH 01/16] ACPI: Don't report current_now if battery reports in mWh Len Brown
` (12 preceding siblings ...)
2010-09-29 3:44 ` [PATCH 14/16] ACPI: fan: Fix more unbalanced code block Len Brown
@ 2010-09-29 3:44 ` Len Brown
2010-09-29 3:44 ` [PATCH 16/16] ACPI: add DMI entry to work around another insane Toshiba BIOS Len Brown
14 siblings, 0 replies; 27+ messages in thread
From: Len Brown @ 2010-09-29 3:44 UTC (permalink / raw)
To: linux-acpi; +Cc: Zhang Rui, Len Brown
From: Zhang Rui <rui.zhang@intel.com>
Disable the Windows Vista (SP1) compatibility for Toshiba P305D.
http://bugzilla.kernel.org/show_bug.cgi?id=14736
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/blacklist.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
index 571a003..f761960 100644
--- a/drivers/acpi/blacklist.c
+++ b/drivers/acpi/blacklist.c
@@ -243,6 +243,14 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
DMI_MATCH(DMI_PRODUCT_NAME, "K50IJ"),
},
},
+ {
+ .callback = dmi_disable_osi_vista,
+ .ident = "Toshiba P305D",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Satellite P305D"),
+ },
+ },
/*
* BIOS invocation of _OSI(Linux) is almost always a BIOS bug.
--
1.7.3.2.g9027fa
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 16/16] ACPI: add DMI entry to work around another insane Toshiba BIOS
2010-09-29 3:44 ` [PATCH 01/16] ACPI: Don't report current_now if battery reports in mWh Len Brown
` (13 preceding siblings ...)
2010-09-29 3:44 ` [PATCH 15/16] ACPI: Disable Windows Vista compatibility for Toshiba P305D Len Brown
@ 2010-09-29 3:44 ` Len Brown
2010-09-29 9:51 ` Anisse Astier
2010-09-29 15:48 ` [PATCH 16/16] ACPI: add DMI entry to work around another insane Toshiba BIOS Matthew Garrett
14 siblings, 2 replies; 27+ messages in thread
From: Len Brown @ 2010-09-29 3:44 UTC (permalink / raw)
To: linux-acpi; +Cc: Len Brown
From: Len Brown <len.brown@intel.com>
Toshiba Satellite C655D-S5048
https://bugzilla.kernel.org/show_bug.cgi?id=14679
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/bus.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 5c221ab..5d48332 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -99,6 +99,14 @@ static struct dmi_system_id dsdt_dmi_table[] __initdata = {
DMI_MATCH(DMI_PRODUCT_NAME, "Satellite L505D"),
},
},
+ {
+ .callback = set_copy_dsdt,
+ .ident = "TOSHIBA Satellite C655D-S5048",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Satellite C655D"),
+ },
+ },
{}
};
#else
--
1.7.3.2.g9027fa
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH 16/16] ACPI: add DMI entry to work around another insane Toshiba BIOS
2010-09-29 3:44 ` [PATCH 16/16] ACPI: add DMI entry to work around another insane Toshiba BIOS Len Brown
@ 2010-09-29 9:51 ` Anisse Astier
2010-09-29 17:38 ` Len Brown
2010-09-29 18:32 ` [PATCH] ACPI: invoke DSDT corruption workaround on all Toshiba Satellite Len Brown
2010-09-29 15:48 ` [PATCH 16/16] ACPI: add DMI entry to work around another insane Toshiba BIOS Matthew Garrett
1 sibling, 2 replies; 27+ messages in thread
From: Anisse Astier @ 2010-09-29 9:51 UTC (permalink / raw)
To: Len Brown; +Cc: linux-acpi
Hi Len,
On Tue, 28 Sep 2010 23:44:46 -0400, Len Brown <lenb@kernel.org> wrote :
> From: Len Brown <len.brown@intel.com>
>
> Toshiba Satellite C655D-S5048
>
> https://bugzilla.kernel.org/show_bug.cgi?id=14679
>
> Signed-off-by: Len Brown <len.brown@intel.com>
Two other case where reported recently; one for which I proposed a patch
almost two months ago:
http://www.spinics.net/lists/linux-acpi/msg29761.html
and another:
http://www.spinics.net/lists/linux-acpi/msg30002.html
If you prefer that I open tickets on bugzilla to process this kind of
bug, please let me know.
Anisse
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 16/16] ACPI: add DMI entry to work around another insane Toshiba BIOS
2010-09-29 9:51 ` Anisse Astier
@ 2010-09-29 17:38 ` Len Brown
2010-09-29 18:32 ` [PATCH] ACPI: invoke DSDT corruption workaround on all Toshiba Satellite Len Brown
1 sibling, 0 replies; 27+ messages in thread
From: Len Brown @ 2010-09-29 17:38 UTC (permalink / raw)
To: Anisse Astier; +Cc: linux-acpi
> If you prefer that I open tickets on bugzilla to process this kind of
> bug, please let me know.
e-mail is normally fastest, but it can be lossy for me,
particularly during summer vacation or when i'm traveling
to a conference for a week. I fully intend to catch up
when i return, but rarely succeed in doing so.
bugzilla never forgets, and last night I scanned through
all the "RESOLVED" ACPI bugs (bugs with patches), which
is why I happened to see the other models before yours.
But I see it now, so you need do nothing more.
Acutally, if you can verify that if you modify the
entry to DMI_MATCH(DMI_PRODUCT_NAME, "Satellite");
that it still works on your Toshiba, that would be great.
Because that is the path forward that seems to make
most sense right now.
thanks,
Len Brown, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH] ACPI: invoke DSDT corruption workaround on all Toshiba Satellite
2010-09-29 9:51 ` Anisse Astier
2010-09-29 17:38 ` Len Brown
@ 2010-09-29 18:32 ` Len Brown
2010-09-30 13:27 ` Anisse Astier
1 sibling, 1 reply; 27+ messages in thread
From: Len Brown @ 2010-09-29 18:32 UTC (permalink / raw)
To: Anisse Astier, Frank, joe; +Cc: linux-acpi
From: Len Brown <len.brown@intel.com>
Our list of Toshiba Satellite models that require this workaround
is growing -- so invoke the workaround for the entire product line.
https://bugzilla.kernel.org/show_bug.cgi?id=14679
Signed-off-by: Len Brown <len.brown@intel.com>
---
Please test this patch.
thanks,
-Len
drivers/acpi/bus.c | 14 +++-----------
1 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 5c221ab..a70ca8e 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -80,23 +80,15 @@ static int set_copy_dsdt(const struct dmi_system_id *id)
static struct dmi_system_id dsdt_dmi_table[] __initdata = {
/*
- * Insyde BIOS on some TOSHIBA machines corrupt the DSDT.
+ * Invoke DSDT corruption work-around on all Toshiba Satellite.
* https://bugzilla.kernel.org/show_bug.cgi?id=14679
*/
{
.callback = set_copy_dsdt,
- .ident = "TOSHIBA Satellite A505",
+ .ident = "TOSHIBA Satellite",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
- DMI_MATCH(DMI_PRODUCT_NAME, "Satellite A505"),
- },
- },
- {
- .callback = set_copy_dsdt,
- .ident = "TOSHIBA Satellite L505D",
- .matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
- DMI_MATCH(DMI_PRODUCT_NAME, "Satellite L505D"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Satellite"),
},
},
{}
--
1.7.3.15.g442cb
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH] ACPI: invoke DSDT corruption workaround on all Toshiba Satellite
2010-09-29 18:32 ` [PATCH] ACPI: invoke DSDT corruption workaround on all Toshiba Satellite Len Brown
@ 2010-09-30 13:27 ` Anisse Astier
2010-10-02 2:54 ` Len Brown
0 siblings, 1 reply; 27+ messages in thread
From: Anisse Astier @ 2010-09-30 13:27 UTC (permalink / raw)
To: Len Brown; +Cc: Frank, joe, linux-acpi
On Wed, 29 Sep 2010 14:32:29 -0400 (EDT), Len Brown <lenb@kernel.org>
wrote :
> From: Len Brown <len.brown@intel.com>
>
> Our list of Toshiba Satellite models that require this workaround
> is growing -- so invoke the workaround for the entire product line.
>
> https://bugzilla.kernel.org/show_bug.cgi?id=14679
>
> Signed-off-by: Len Brown <len.brown@intel.com>
> ---
>
> Please test this patch.
> thanks,
> -Len
>
> drivers/acpi/bus.c | 14 +++-----------
> 1 files changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index 5c221ab..a70ca8e 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -80,23 +80,15 @@ static int set_copy_dsdt(const struct dmi_system_id *id)
>
> static struct dmi_system_id dsdt_dmi_table[] __initdata = {
> /*
> - * Insyde BIOS on some TOSHIBA machines corrupt the DSDT.
> + * Invoke DSDT corruption work-around on all Toshiba Satellite.
> * https://bugzilla.kernel.org/show_bug.cgi?id=14679
> */
> {
> .callback = set_copy_dsdt,
> - .ident = "TOSHIBA Satellite A505",
> + .ident = "TOSHIBA Satellite",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
> - DMI_MATCH(DMI_PRODUCT_NAME, "Satellite A505"),
> - },
> - },
> - {
> - .callback = set_copy_dsdt,
> - .ident = "TOSHIBA Satellite L505D",
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
Isn't that a bit too broad? Maybe we should keep "TOSHIBA" in case
another vendor decides to add "Satellite" in its DMI product name.
> - DMI_MATCH(DMI_PRODUCT_NAME, "Satellite L505D"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Satellite"),
> },
> },
> {}
Anyway, this works well on Toshiba Satellite C650D.
Tested-by: Anisse Astier <anisse@astier.eu>
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCH] ACPI: invoke DSDT corruption workaround on all Toshiba Satellite
2010-09-30 13:27 ` Anisse Astier
@ 2010-10-02 2:54 ` Len Brown
0 siblings, 0 replies; 27+ messages in thread
From: Len Brown @ 2010-10-02 2:54 UTC (permalink / raw)
To: Anisse Astier; +Cc: Frank, joe, linux-acpi
> > Please test this patch.
> > drivers/acpi/bus.c | 14 +++-----------
> > 1 files changed, 3 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> > index 5c221ab..a70ca8e 100644
> > --- a/drivers/acpi/bus.c
> > +++ b/drivers/acpi/bus.c
> > @@ -80,23 +80,15 @@ static int set_copy_dsdt(const struct dmi_system_id *id)
> >
> > static struct dmi_system_id dsdt_dmi_table[] __initdata = {
> > /*
> > - * Insyde BIOS on some TOSHIBA machines corrupt the DSDT.
> > + * Invoke DSDT corruption work-around on all Toshiba Satellite.
> > * https://bugzilla.kernel.org/show_bug.cgi?id=14679
> > */
> > {
> > .callback = set_copy_dsdt,
> > - .ident = "TOSHIBA Satellite A505",
> > + .ident = "TOSHIBA Satellite",
> > .matches = {
> > DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
> > - DMI_MATCH(DMI_PRODUCT_NAME, "Satellite A505"),
> > - },
> > - },
> > - {
> > - .callback = set_copy_dsdt,
> > - .ident = "TOSHIBA Satellite L505D",
> > - .matches = {
> > - DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
> Isn't that a bit too broad? Maybe we should keep "TOSHIBA" in case
> another vendor decides to add "Satellite" in its DMI product name.
We kept it -- it is the 1st line above without a '-' in fron of it.
> > - DMI_MATCH(DMI_PRODUCT_NAME, "Satellite L505D"),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "Satellite"),
> > },
> > },
> > {}
>
> Anyway, this works well on Toshiba Satellite C650D.
>
> Tested-by: Anisse Astier <anisse@astier.eu>
Thanks very much for testing.
cheers,
Len Brown, Intel Open Souce Technology Center
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 16/16] ACPI: add DMI entry to work around another insane Toshiba BIOS
2010-09-29 3:44 ` [PATCH 16/16] ACPI: add DMI entry to work around another insane Toshiba BIOS Len Brown
2010-09-29 9:51 ` Anisse Astier
@ 2010-09-29 15:48 ` Matthew Garrett
2010-09-29 17:27 ` Len Brown
1 sibling, 1 reply; 27+ messages in thread
From: Matthew Garrett @ 2010-09-29 15:48 UTC (permalink / raw)
To: Len Brown; +Cc: linux-acpi, Len Brown
On Tue, Sep 28, 2010 at 11:44:46PM -0400, Len Brown wrote:
> From: Len Brown <len.brown@intel.com>
>
> Toshiba Satellite C655D-S5048
Why are we not making this the default behaviour, perhaps with a boot or
config option to disable it if people really can't live with the memory
hit?
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 16/16] ACPI: add DMI entry to work around another insane Toshiba BIOS
2010-09-29 15:48 ` [PATCH 16/16] ACPI: add DMI entry to work around another insane Toshiba BIOS Matthew Garrett
@ 2010-09-29 17:27 ` Len Brown
2010-09-29 17:32 ` Matthew Garrett
0 siblings, 1 reply; 27+ messages in thread
From: Len Brown @ 2010-09-29 17:27 UTC (permalink / raw)
To: Matthew Garrett; +Cc: linux-acpi
> On Tue, Sep 28, 2010 at 11:44:46PM -0400, Len Brown wrote:
> > From: Len Brown <len.brown@intel.com>
> >
> > Toshiba Satellite C655D-S5048
>
> Why are we not making this the default behaviour, perhaps with a boot or
> config option to disable it if people really can't live with the memory
> hit?
It looks like only Toshiba Satellite have this flaw.
It would not be fair to every Linux/ACPI system out there
to double ACPI table size because of bugs at Toshiba.
Perhaps we should wild-card and make this the default
for all Toshiba Satellite. I expect we can do this
simply by leaving the model number off. eg
- DMI_MATCH(DMI_PRODUCT_NAME, "Satellite L505D"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Satellite"),
The down-side, of course, is that Satellite's in the future
will continue to pay for the bugs of Satellite's past --
but I'd not lose any sleep over that.
thanks,
Len Brown, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 16/16] ACPI: add DMI entry to work around another insane Toshiba BIOS
2010-09-29 17:27 ` Len Brown
@ 2010-09-29 17:32 ` Matthew Garrett
2010-09-29 17:53 ` Len Brown
0 siblings, 1 reply; 27+ messages in thread
From: Matthew Garrett @ 2010-09-29 17:32 UTC (permalink / raw)
To: Len Brown; +Cc: linux-acpi
On Wed, Sep 29, 2010 at 01:27:23PM -0400, Len Brown wrote:
> It looks like only Toshiba Satellite have this flaw.
If the Leading Other OS is liberal in what it accepts, we're leaving
ourselves open to reduced compatibility if someone else ends up making
the same mistake. The hit looks to be around 300K or less.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 16/16] ACPI: add DMI entry to work around another insane Toshiba BIOS
2010-09-29 17:32 ` Matthew Garrett
@ 2010-09-29 17:53 ` Len Brown
0 siblings, 0 replies; 27+ messages in thread
From: Len Brown @ 2010-09-29 17:53 UTC (permalink / raw)
To: Matthew Garrett; +Cc: linux-acpi
> > It looks like only Toshiba Satellite have this flaw.
>
> If the Leading Other OS is liberal in what it accepts, we're leaving
> ourselves open to reduced compatibility if someone else ends up making
> the same mistake. The hit looks to be around 300K or less.
We've been "open" to this issue ever since we started using
ACPI tables "in-place" many years ago. Only Toshiba Satellite
has failed. Also, now we check for table corruption.
I think there need to be limits on the extent that we make
Linux stupid in the name of Windows bug compatibility.
If we find that many vendors and models run into this,
we can always re-consider.
thanks,
Len Brown, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 27+ messages in thread