public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: "Moore, Robert" <robert.moore@intel.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 1/5] ACPI: Allow handlers to be installed at the same time as methods
Date: Wed, 6 Oct 2010 21:30:27 +0200	[thread overview]
Message-ID: <201010062130.27564.rjw@sisk.pl> (raw)
In-Reply-To: <20101006161854.GA30584@srcf.ucam.org>

On Wednesday, October 06, 2010, Matthew Garrett wrote:
> On Wed, Oct 06, 2010 at 09:14:07AM -0700, Moore, Robert wrote:
> 
> > Although there exists a single Windows document mentions this behavior as a windows "feature", I'm not 100% convinced that this is actually true. AFAIK, we've never seen a machine that depends on an "implicit notify" on a device when a wake GPE happens.
> 
> Such behaviour would be irrelevant for system sleep/wake - the only 
> requirement is in runtime power management.
> 
> > It appears to me that the biggest issue right now is the fact that a Notify() must be performed on a Device object, and the problem is how to associate the GPE with the device object.
> 
> The other important aspect of this is that a single GPE may correspond 
> to multiple devices. The methods will generally cope with this by either 
> sending multiple notifies, executing some SMM code to identify the 
> relevant device or reading PCI configuration registers to identify the 
> source of the wakeup. We need to handle that case as well.

So, as I said, we can modify acpi_gpe_can_wake() to pass a device object to
ACPICA.  Then, the device object will be added to the list of devices to Notify()
if the GPE is signaled.  Plain and simple.

Thanks,
Rafael

  reply	other threads:[~2010-10-06 19:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-04 18:22 Runtime PM: Improve support for PCI devices Matthew Garrett
2010-10-04 18:22 ` [PATCH 1/5] ACPI: Allow handlers to be installed at the same time as methods Matthew Garrett
2010-10-05 23:18   ` Rafael J. Wysocki
2010-10-06  2:09     ` Moore, Robert
2010-10-06 16:14     ` Moore, Robert
2010-10-06 16:18       ` Matthew Garrett
2010-10-06 19:30         ` Rafael J. Wysocki [this message]
2010-10-06 19:32           ` Matthew Garrett
2010-10-06 19:47           ` Moore, Robert
2010-10-04 18:22 ` [PATCH 2/5] pci: Export some PCI PM functionality Matthew Garrett
2010-10-05 23:20   ` Rafael J. Wysocki
2010-10-15 20:10   ` Jesse Barnes
2010-10-04 18:22 ` [PATCH 3/5] ACPI: Bind implicit GPE dependencies to PCI devices Matthew Garrett
2010-10-05 23:37   ` Rafael J. Wysocki
2010-10-04 18:22 ` [PATCH 4/5] ACPI: Missing _S0W shouldn't disable runtime PM Matthew Garrett
2010-10-04 18:22 ` [PATCH 5/5] pci: Add support for polling PME state on suspended legacy PCI devices Matthew Garrett
2010-10-05 23:45   ` Rafael J. Wysocki
2010-10-15 20:10   ` Jesse Barnes
2010-10-15 20:39     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201010062130.27564.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox