From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH 5/5] pci: Add support for polling PME state on suspended legacy PCI devices Date: Fri, 15 Oct 2010 22:39:50 +0200 Message-ID: <201010152239.50316.rjw@sisk.pl> References: <1286216549-5438-1-git-send-email-mjg@redhat.com> <1286216549-5438-6-git-send-email-mjg@redhat.com> <20101015131028.7fffba40@jbarnes-desktop> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from ogre.sisk.pl ([217.79.144.158]:50709 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932105Ab0JOUk5 (ORCPT ); Fri, 15 Oct 2010 16:40:57 -0400 In-Reply-To: <20101015131028.7fffba40@jbarnes-desktop> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Jesse Barnes Cc: Matthew Garrett , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org On Friday, October 15, 2010, Jesse Barnes wrote: > On Mon, 4 Oct 2010 14:22:29 -0400 > Matthew Garrett wrote: > > > Not all hardware vendors hook up the PME line for legacy PCI devices, > > meaning that wakeup events get lost. The only way around this is to poll > > the devices to see if their state has changed, so add support for doing > > that on legacy PCI devices that aren't part of the core chipset. > > > > Signed-off-by: Matthew Garrett > > --- > > drivers/pci/pci.c | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 files changed, 77 insertions(+), 0 deletions(-) > > Yuck, polling. But I guess we don't have an alternative short of > rewiring all the cheap platforms out there! > > So, applied. Actually, the next step should be to avoid polling for the devices that do signal wakeup normally. That is, if wakeup interrupts or notifications are coming for the device, we'll drop it from the list. This looks doable. Thanks, Rafael