* [PATCH] ACPI / PM: Blacklist another machine that needs acpi_sleep=nonvs
@ 2010-10-17 19:01 Rafael J. Wysocki
2010-10-26 0:14 ` Len Brown
0 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2010-10-17 19:01 UTC (permalink / raw)
To: Len Brown
Cc: ACPI Devel Maling List, Linux-pm mailing list, Emanuele Bigiarini
From: Rafael J. Wysocki <rjw@sisk.pl>
Sony Vaio VPCEB1Z1E is reported to require acpi_sleep=nonvs for
suspend/resume to work on it correctly, so blacklist it.
Reported-by: Emanuele Bigiarini <pulmro@gmail.com>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/acpi/sleep.c | 8 ++++++++
1 file changed, 8 insertions(+)
Index: linux-2.6/drivers/acpi/sleep.c
===================================================================
--- linux-2.6.orig/drivers/acpi/sleep.c
+++ linux-2.6/drivers/acpi/sleep.c
@@ -419,6 +419,14 @@ static struct dmi_system_id __initdata a
DMI_MATCH(DMI_PRODUCT_NAME, "Everex StepNote Series"),
},
},
+ {
+ .callback = init_nvs_nosave,
+ .ident = "Sony Vaio VPCEB1Z1E",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "VPCEB1Z1E"),
+ },
+ },
{},
};
#endif /* CONFIG_SUSPEND */
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ACPI / PM: Blacklist another machine that needs acpi_sleep=nonvs
2010-10-17 19:01 [PATCH] ACPI / PM: Blacklist another machine that needs acpi_sleep=nonvs Rafael J. Wysocki
@ 2010-10-26 0:14 ` Len Brown
2010-10-26 13:19 ` Matthew Garrett
0 siblings, 1 reply; 6+ messages in thread
From: Len Brown @ 2010-10-26 0:14 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: ACPI Devel Maling List, Linux-pm mailing list, Emanuele Bigiarini
Rather than a black list of machines that can not survive saving NVS,
I wonder how long a white list of machines requiring NVS save would be?
applied.
thanks,
Len Brown, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI / PM: Blacklist another machine that needs acpi_sleep=nonvs
2010-10-26 0:14 ` Len Brown
@ 2010-10-26 13:19 ` Matthew Garrett
2010-10-26 18:49 ` Rafael J. Wysocki
0 siblings, 1 reply; 6+ messages in thread
From: Matthew Garrett @ 2010-10-26 13:19 UTC (permalink / raw)
To: Len Brown
Cc: Rafael J. Wysocki, ACPI Devel Maling List, Linux-pm mailing list,
Emanuele Bigiarini
On Mon, Oct 25, 2010 at 08:14:42PM -0400, Len Brown wrote:
> Rather than a black list of machines that can not survive saving NVS,
> I wonder how long a white list of machines requiring NVS save would be?
Windows saves the NVS area in my testing. Either there's something that
indicates the choices of one behaviour over the other, or the machines
that are broken by NVS saving are actually tripping some other bug.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI / PM: Blacklist another machine that needs acpi_sleep=nonvs
2010-10-26 13:19 ` Matthew Garrett
@ 2010-10-26 18:49 ` Rafael J. Wysocki
2010-10-26 19:21 ` Len Brown
0 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2010-10-26 18:49 UTC (permalink / raw)
To: Matthew Garrett
Cc: Len Brown, ACPI Devel Maling List, Linux-pm mailing list,
Emanuele Bigiarini
On Tuesday, October 26, 2010, Matthew Garrett wrote:
> On Mon, Oct 25, 2010 at 08:14:42PM -0400, Len Brown wrote:
> > Rather than a black list of machines that can not survive saving NVS,
> > I wonder how long a white list of machines requiring NVS save would be?
>
> Windows saves the NVS area in my testing. Either there's something that
> indicates the choices of one behaviour over the other, or the machines
> that are broken by NVS saving are actually tripping some other bug.
Since we're claiming Windows compatibility through _OSI, we should follow
Windows except for on machines that are blacklisted as not being
Windows-compatible.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI / PM: Blacklist another machine that needs acpi_sleep=nonvs
2010-10-26 18:49 ` Rafael J. Wysocki
@ 2010-10-26 19:21 ` Len Brown
2010-10-26 19:23 ` Matthew Garrett
0 siblings, 1 reply; 6+ messages in thread
From: Len Brown @ 2010-10-26 19:21 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Matthew Garrett, ACPI Devel Maling List, Linux-pm mailing list,
Emanuele Bigiarini
> Windows-compatible.
Matthew,
Exactly what version of Windows did you test to be saving NVS?
Is it possible that different versions of Windows behave differently?
thanks,
Len Brown, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI / PM: Blacklist another machine that needs acpi_sleep=nonvs
2010-10-26 19:21 ` Len Brown
@ 2010-10-26 19:23 ` Matthew Garrett
0 siblings, 0 replies; 6+ messages in thread
From: Matthew Garrett @ 2010-10-26 19:23 UTC (permalink / raw)
To: Len Brown
Cc: Rafael J. Wysocki, ACPI Devel Maling List, Linux-pm mailing list,
Emanuele Bigiarini
On Tue, Oct 26, 2010 at 03:21:15PM -0400, Len Brown wrote:
> > Windows-compatible.
>
> Matthew,
> Exactly what version of Windows did you test to be saving NVS?
> Is it possible that different versions of Windows behave differently?
XP. It's certainly possible that later versions behave differently -
I'll have to go back and check the original machine that had this
problem to see which _OSI calls it makes. It may be that querying Vista
or 7 disables this functionality.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-10-26 19:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-17 19:01 [PATCH] ACPI / PM: Blacklist another machine that needs acpi_sleep=nonvs Rafael J. Wysocki
2010-10-26 0:14 ` Len Brown
2010-10-26 13:19 ` Matthew Garrett
2010-10-26 18:49 ` Rafael J. Wysocki
2010-10-26 19:21 ` Len Brown
2010-10-26 19:23 ` Matthew Garrett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).