From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Len Brown <lenb@kernel.org>, linux-acpi@vger.kernel.org
Subject: Re: ACPI: Fix <acpi/video.h> when CONFIG_ACPI_VIDEO=n
Date: Fri, 19 Nov 2010 17:14:20 -0800 [thread overview]
Message-ID: <20101120011420.GA2862@ericsson.com> (raw)
In-Reply-To: <20101119170200.2db4ab81@endymion.delvare>
On Fri, Nov 19, 2010 at 04:02:00PM -0000, Jean Delvare wrote:
> Building the kernel (2.6.37-rc2-git5) with CONFIG_ACPI_VIDEO=n fails
> for me because of these errors:
>
> include/acpi/video.h:22:11: warning: "struct acpi_device" declared inside parameter list
> include/acpi/video.h:22:11: warning: its scope is only this definition or declaration, which is probably not what you want
> include/acpi/video.h: In function "acpi_video_get_edid":
> include/acpi/video.h:24:10: error: "ENODEV" undeclared (first use in this function)
> include/acpi/video.h:24:10: note: each undeclared identifier is reported only once for each function it appears in
>
> Adding the missing include and structure declaration fixes it.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
Yes, it would be great if someone would apply one of the patches.
Build fails for me with CONFIG_PM=n.
Guenter
prev parent reply other threads:[~2010-11-20 1:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 16:02 [PATCH] ACPI: Fix <acpi/video.h> when CONFIG_ACPI_VIDEO=n Jean Delvare
2010-11-19 16:36 ` Randy Dunlap
2010-11-20 1:14 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101120011420.GA2862@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=khali@linux-fr.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox