From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Thomas Renninger <trenn@suse.de>
Cc: arjan@linux.intel.com, lenb@kernel.org,
linux-acpi@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] cpuidle: Rename X86 specific idle poll state[0] from C0 to CPUIDLE
Date: Thu, 2 Dec 2010 10:31:17 -0700 [thread overview]
Message-ID: <201012021031.19779.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <1291308148-28628-3-git-send-email-trenn@suse.de>
On Thursday, December 02, 2010 09:42:22 am Thomas Renninger wrote:
> C0 means and is well know as "not idle".
> All documentation out there uses this term as "running"/"not idle"
> state. Also Linux userspace tools (e.g. cpufreq-aperf and turbostat)
> show C0 residency which there is correct, but means something totally
> else than cpuidle "POLL" state.
>
>
> Signed-off-by: Thomas Renninger <trenn@suse.de>
> CC: arjan@linux.intel.com
> CC: lenb@kernel.org
> CC: linux-acpi@vger.kernel.org
> CC: Ingo Molnar <mingo@elte.hu>
> CC: linux-kernel@vger.kernel.org
> ---
> drivers/cpuidle/cpuidle.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> index 08d5f05..99cc8fc 100644
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -260,7 +260,7 @@ static void poll_idle_init(struct cpuidle_device *dev)
>
> cpuidle_set_statedata(state, NULL);
>
> - snprintf(state->name, CPUIDLE_NAME_LEN, "C0");
> + snprintf(state->name, CPUIDLE_NAME_LEN, "POLL");
The description says "rename C0 to CPUIDLE", but the patch looks like
"rename C0 to POLL".
> snprintf(state->desc, CPUIDLE_DESC_LEN, "CPUIDLE CORE POLL IDLE");
> state->exit_latency = 0;
> state->target_residency = 0;
>
prev parent reply other threads:[~2010-12-02 17:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1291308148-28628-1-git-send-email-trenn@suse.de>
2010-12-02 16:42 ` [PATCH 1/8] acpi: Use ACPI C-state type instead of enumeration value to export cpuidle state name Thomas Renninger
2010-12-02 16:42 ` [PATCH 2/8] cpuidle: Rename X86 specific idle poll state[0] from C0 to CPUIDLE Thomas Renninger
2010-12-02 16:42 ` [PATCH 3/8] X86/perf: fix power:cpu_idle double end events and throw cpu_idle events from the cpuidle layer Thomas Renninger
2010-12-02 16:42 ` [PATCH 4/8] X86: Cleanup idle= internal variables by getting rid of idle_halt idle_nomwait Thomas Renninger
2010-12-02 16:42 ` [PATCH 5/8] cpuidle: Introduce .abbr (abbrevation) for cpuidle states Thomas Renninger
2010-12-02 16:42 ` [PATCH 6/8] acpi: processor->cpuidle: Only set cpuidle check_bm flag if pr->flags.bm_check is set Thomas Renninger
2010-12-02 16:42 ` [PATCH 7/8] perf timechart: Map power:cpu_idle events to the corresponding cpuidle state Thomas Renninger
2010-12-02 16:51 ` Thomas Renninger
2010-12-02 17:33 ` [PATCH 5/8] cpuidle: Introduce .abbr (abbrevation) for cpuidle states Bjorn Helgaas
2010-12-02 17:31 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012021031.19779.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=arjan@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox