Re: [PATCH 3/3] ACPI: Bug compatibility for Windows on the ACPI reboot vector

H. Peter Anvin
2010-12-09T22:36:41Z

On 12/09/2010 01:46 PM, Matthew Garrett wrote:
> Windows ignores the bit_offset and bit_width, despite the spec requiring
> that they be validated. Drop the checks so that we match this behaviour.
> Windows also goes straight for the keyboard controller if the ACPI reboot
> fails, so we shouldn't sleep if we're still alive.
>
> Signed-off-by: Matthew Garrett<mjg@redhat.com>

Be careful: the goal isn't bug-compatibility with Windows, the goal is
to work on the maximum number of systems. Bug-compatibility with
Windows *may* be a way to that goal, but it is not a guarantee, since
Windows doesn't get validated against older systems that went through
WHQL under an earlier version of Windows.

-hpa