Re: [PATCH 2/3] ACPICA: Fix access width for reset vector

Rafael J. Wysocki
2010-12-09T22:41:51Z

On Thursday, December 09, 2010, Matthew Garrett wrote:
> Section 4.7.3.6 of the ACPI specification requires that the register width
> of the reset vector be 8 bits. Windows simply hardcodes the access to be
> a byte and ignores the width provided in the FADT, so make sure that we
> do the same.
>
> Signed-off-by: Matthew Garrett <mjg@redhat.com>

Acked-by: Rafael J. Wysocki <rjw@sisk.pl>

> ---
> drivers/acpi/acpica/hwxface.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/acpica/hwxface.c b/drivers/acpi/acpica/hwxface.c
> index 50cc3be..c6a4e63 100644
> --- a/drivers/acpi/acpica/hwxface.c
> +++ b/drivers/acpi/acpica/hwxface.c
> @@ -82,12 +82,11 @@ acpi_status acpi_reset(void)
> /*
> * For I/O space, write directly to the OSL. This bypasses the port
> * validation mechanism, which may block a valid write to the reset
> - * register.
> + * register. Spec section 4.7.3.6 requires register width to be 8.
> */
> status =
> acpi_os_write_port((acpi_io_address) reset_reg->address,
> - acpi_gbl_FADT.reset_value,
> - reset_reg->bit_width);
> + acpi_gbl_FADT.reset_value, 8)
> } else {
> /* Write the reset value to the reset register */
>
>