From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Len Brown <lenb@kernel.org>, Bob Moore <robert.moore@intel.com>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/6] ACPICA: Rename some function and variable names
Date: Thu, 9 Dec 2010 22:59:38 +0100 [thread overview]
Message-ID: <201012092259.38254.rjw@sisk.pl> (raw)
In-Reply-To: <1291651120.2197.80.camel@localhost>
On Monday, December 06, 2010, Lin Ming wrote:
> Some function and variable names are renamed to be consistent with
> ACPICA code base.
>
> acpi_raw_enable_gpe -> acpi_ev_add_gpe_reference
> acpi_raw_disable_gpe -> acpi_ev_remove_gpe_reference
> acpi_gpe_can_wake -> acpi_setup_gpe_for_wake
> acpi_gpe_wakeup -> acpi_set_gpe_wake_mask
> acpi_update_gpes -> acpi_update_all_gpes
> acpi_all_gpes_initialized -> acpi_gbl_all_gpes_initialized
> acpi_handler_info -> acpi_gpe_handler_info
> ...
>
> Signed-off-by: Lin Ming <ming.m.lin@intel.com>
Well, tha changes related to acpi_ev_gpe_dispatch() do not really match the
changelog. I'd prefer them to go into a separate patch with the right
description.
...
> u32
> -acpi_ev_gpe_dispatch(struct acpi_gpe_event_info *gpe_event_info,
> +acpi_ev_gpe_dispatch(struct acpi_namespace_node *gpe_device,
> + struct acpi_gpe_event_info *gpe_event_info,
> u32 gpe_number);
>
...
> int_status |=
> - acpi_ev_gpe_dispatch(&gpe_block->
> + acpi_ev_gpe_dispatch(gpe_block->
> + node,
> + &gpe_block->
> event_info[((acpi_size) i * ACPI_GPE_REGISTER_WIDTH) + j], j + gpe_register_info->base_gpe_number);
> }
> }
...
> @@ -589,7 +597,9 @@ acpi_ev_gpe_dispatch(struct acpi_gpe_event_info *gpe_event_info, u32 gpe_number)
> * Ignore return status for now.
> * TBD: leave GPE disabled on error?
> */
> - (void)gpe_event_info->dispatch.handler->address(gpe_event_info->
> + (void)gpe_event_info->dispatch.handler->address(gpe_device,
> + gpe_number,
> + gpe_event_info->
> dispatch.
> handler->
> context);
...
Thanks,
Rafael
next prev parent reply other threads:[~2010-12-09 22:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 15:58 [PATCH 2/6] ACPICA: Rename some function and variable names Lin Ming
2010-12-09 21:59 ` Rafael J. Wysocki [this message]
2010-12-09 22:33 ` Moore, Robert
2010-12-09 22:51 ` Rafael J. Wysocki
2010-12-09 22:53 ` Moore, Robert
2010-12-09 23:04 ` Rafael J. Wysocki
2010-12-09 23:13 ` Moore, Robert
[not found] ` <2B60D52015C3A84D9B0C6DFBF46A9C9F01B7892217@orsmsx503.amr.corp.intel.com>
2010-12-10 1:09 ` Moore, Robert
2010-12-10 0:25 ` Lin Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012092259.38254.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox