From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 1/5] resources: add arch hook for preventing allocation in reserved areas Date: Fri, 10 Dec 2010 17:37:49 -0800 Message-ID: <20101210173749.7ec3cc28@jbarnes-desktop> References: <20101208213606.13026.47657.stgit@bob.kio> <20101210123008.7fed582d@jbarnes-desktop> <20101210123609.73c12a23@jbarnes-desktop> <201012101407.24419.bjorn.helgaas@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201012101407.24419.bjorn.helgaas@hp.com> Sender: linux-pci-owner@vger.kernel.org To: Bjorn Helgaas Cc: Len Brown , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, "H. Peter Anvin" , Thomas Gleixner , Linus Torvalds , Ingo Molnar , Adam Belay , Matthew Garrett , Dan Williams , rjw@sisk.pl List-Id: linux-acpi@vger.kernel.org On Fri, 10 Dec 2010 14:07:24 -0700 Bjorn Helgaas wrote: > On Friday, December 10, 2010 01:36:09 pm Jesse Barnes wrote: > > [Actually cc'ing Matthew this time] > > > > On Fri, 10 Dec 2010 12:30:08 -0800 > > Jesse Barnes wrote: > > > > > On Wed, 08 Dec 2010 14:36:06 -0700 > > > Bjorn Helgaas wrote: > > > > > > > > > > > This adds arch_remove_reservations(), which an arch can implement if it > > > > needs to protect part of the address space from allocation. > > > > > > > > Sometimes that can be done by just requesting a resource. This hook is to > > > > cover cases where protected area doesn't fit well in the hierarchical > > > > resource tree. For example, x86 BIOS E820 reservations are not related > > > > to devices, so they may overlap part of, all of, or more than a device > > > > resource. > > > > > > > > Signed-off-by: Bjorn Helgaas > > > > --- > > > > > > Hm, this is bigger than the simple change of just avoiding the high 2M; > > > Linus have you checked it out yet? It's nicer than simply adjusting > > > PCIBIOS_MAX_MEM since it will affect all resource callers rather than > > > just PCI, but it's definitely bigger. > > Dan Williams also reproduced the problem on a 2530p and tested this > series (though I think he actually tested a backport in Fedora): > https://bugzilla.kernel.org/show_bug.cgi?id=23542#c7 > https://bugzilla.kernel.org/show_bug.cgi?id=23542#c23 > > The simple PCIBIOS_MAX_MEM_32 change below will fix the 2530p problem, > but it won't help fix the nx6325 problem Rafael reported; details at: > https://bugzilla.kernel.org/show_bug.cgi?id=23332#c20 > > Rafael did confirm on #acpi Wednesday that the full series fixed > his nx6325. Thanks, I'll add Dan and Rafael's tested-bys to the patches (they're already in my for-linus tree). Unless Linus has a problem with them I'll send them over to him this weekend or Monday. -- Jesse Barnes, Intel Open Source Technology Center