From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Zhang Rui <rui.zhang@intel.com>
Cc: "x86@kernel.org" <x86@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"lenb@kernel.org" <lenb@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI: Make sure the FADT is at least rev 2 before using the reset register
Date: Mon, 13 Dec 2010 00:21:38 +0000 [thread overview]
Message-ID: <20101213002138.GA5164@srcf.ucam.org> (raw)
In-Reply-To: <1292199396.1715.143.camel@rui>
On Mon, Dec 13, 2010 at 08:16:36AM +0800, Zhang Rui wrote:
> On Sat, 2010-12-11 at 01:57 +0800, Matthew Garrett wrote:
> > The reset register was only introduced with version 2 of the FADT, so we
> > should check that the FADT revision before trusting its contents.
> >
> does the current code break anything?
> I'm curious about how you found this bug. :)
No, it just seems to be a sensible sanity check.
prev parent reply other threads:[~2010-12-13 0:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 17:57 [PATCH] ACPI: Make sure the FADT is at least rev 2 before using the reset register Matthew Garrett
2010-12-13 0:16 ` Zhang Rui
2010-12-13 0:21 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101213002138.GA5164@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox