From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Jan Beulich <JBeulich@novell.com>
Cc: Len Brown <lenb@kernel.org>,
Linux-pm mailing list <linux-pm@lists.linux-foundation.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: Wrong commit in the ACPI release branch
Date: Mon, 13 Dec 2010 22:09:16 +0100 [thread overview]
Message-ID: <201012132209.17173.rjw@sisk.pl> (raw)
In-Reply-To: <4D05E1E502000078000277B6@vpn.id2.novell.com>
On Monday, December 13, 2010, Jan Beulich wrote:
> >>> On 11.12.10 at 23:29, "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> > The following commit:
> >
> > http://git.kernel.org/?p=linux/kernel/git/lenb/linux-acpi-2.6.git;a=commit;h
> > =091aad6af4ab29af693ced5d6970ceee9d5981c8
> >
> > (ACPI: eliminate unused variable warning for !ACPI_SLEEP)
> > is actually wrong, because it's going to break compilation for
> > (!CONFIG_PM_SLEEP && CONFIG_PM_RUNTIME).
>
> How would this break compilation in *any* configuration? The
> variable definition got moved into an #ifdef the #else of which
> has
>
> #define acpi_target_sleep_state ACPI_STATE_S0
OK, I seem to haven't looked at the patch carefully enough, sorry for the
noise.
Rafael
next prev parent reply other threads:[~2010-12-13 21:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-11 22:29 Wrong commit in the ACPI release branch Rafael J. Wysocki
2010-12-13 8:05 ` Jan Beulich
2010-12-13 21:09 ` Rafael J. Wysocki [this message]
2010-12-13 20:11 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012132209.17173.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=JBeulich@novell.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox