Wrong commit in the ACPI release branch

Wrong commit in the ACPI release branch

[Rafael J. Wysocki]

Hi Len,

The following commit:

http://git.kernel.org/?p=linux/kernel/git/lenb/linux-acpi-2.6.git;a=commit;h=091aad6af4ab29af693ced5d6970ceee9d5981c8

(ACPI: eliminate unused variable warning for !ACPI_SLEEP)
is actually wrong, because it's going to break compilation for
(!CONFIG_PM_SLEEP && CONFIG_PM_RUNTIME).

I haven't seen it before, let alone acking it or something like this, so I wonder
why it's being pushed directly to Linus?

Thanks,
Rafael

Re: Wrong commit in the ACPI release branch

[Jan Beulich]

>>> On 11.12.10 at 23:29, "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> The following commit:
> 
> http://git.kernel.org/?p=linux/kernel/git/lenb/linux-acpi-2.6.git;a=commit;h 
> =091aad6af4ab29af693ced5d6970ceee9d5981c8
> 
> (ACPI: eliminate unused variable warning for !ACPI_SLEEP)
> is actually wrong, because it's going to break compilation for
> (!CONFIG_PM_SLEEP && CONFIG_PM_RUNTIME).

How would this break compilation in *any* configuration? The
variable definition got moved into an #ifdef the #else of which
has

#define acpi_target_sleep_state	ACPI_STATE_S0

Jan

Re: Wrong commit in the ACPI release branch

[Len Brown]

On Sat, 11 Dec 2010, Rafael J. Wysocki wrote:

> http://git.kernel.org/?p=linux/kernel/git/lenb/linux-acpi-2.6.git;a=commit;h=091aad6af4ab29af693ced5d6970ceee9d5981c8
> 
> (ACPI: eliminate unused variable warning for !ACPI_SLEEP)
> is actually wrong, because it's going to break compilation for
> (!CONFIG_PM_SLEEP && CONFIG_PM_RUNTIME).

That's funny, that config builds for me.
It got through my 399 kernel build test, as well as linux-next.

If you have a .config that breaks, please send it to me.

> I haven't seen it before, let alone acking it or something like this, so I wonder
> why it's being pushed directly to Linus?

it fixes an unused variable warning if !CONFG_ACPI_SLEEP, per the commit 
message.

thanks,
Len Brown, Intel Open Source Technology Center

Re: Wrong commit in the ACPI release branch

[Rafael J. Wysocki]

On Monday, December 13, 2010, Jan Beulich wrote:
> >>> On 11.12.10 at 23:29, "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> > The following commit:
> > 
> > http://git.kernel.org/?p=linux/kernel/git/lenb/linux-acpi-2.6.git;a=commit;h 
> > =091aad6af4ab29af693ced5d6970ceee9d5981c8
> > 
> > (ACPI: eliminate unused variable warning for !ACPI_SLEEP)
> > is actually wrong, because it's going to break compilation for
> > (!CONFIG_PM_SLEEP && CONFIG_PM_RUNTIME).
> 
> How would this break compilation in *any* configuration? The
> variable definition got moved into an #ifdef the #else of which
> has
> 
> #define acpi_target_sleep_state	ACPI_STATE_S0

OK, I seem to haven't looked at the patch carefully enough, sorry for the
noise.

Rafael