From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [Resend][PATCH 0/3] ACPI / PM: Patches missing from linux-acpi-2.6/test Date: Mon, 13 Dec 2010 22:11:29 +0100 Message-ID: <201012132211.29221.rjw@sisk.pl> References: <201012112339.53105.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from ogre.sisk.pl ([217.79.144.158]:52189 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751678Ab0LMVMC (ORCPT ); Mon, 13 Dec 2010 16:12:02 -0500 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Len Brown Cc: ACPI Devel Maling List , Linux-pm mailing list , Matthew Garrett On Monday, December 13, 2010, Len Brown wrote: > > Hi Len, > > > > The following three patches seem to have been dropped from your 'test' branch. > > > > If that happened by accident, please reapply. Otherwise, please let me know > > what's wrong with the patches so that I can fix them. > > > > [1/3] - Make fujitsu_laptop use acpi_bus_update_power() instead of > > acpi_bus_get_power() which is unsafe. > > > > [2/3] - Drop acpi_bus_get_power() which is unsafe and has no users. > > > > [3/3] - Do not call __acpi_bus_get_power() from acpi_bus_set_power() > > and remove acpi_power_nocheck that is not necessary any more. > > > > Without these patches the power resources handling rework is incomplete and > > the code will not work correctly in some situations. > > Looks like my screw-up. > > I recall inserting the fujitsu patch to fix the > build before what were originally 12/13 and 13/13 of this series, > but apparently I kept the baseline branch and deleted the fix on top of it. > > Yes, in general, I do squawk when I drop patches from acpi-test, > even if it is a temporary drop due to a time-consuming manual merge. > > So thanks for noticing, I'll look at these again now. Thanks! Rafael