Re: [PATCH 5/5] PNP: HP nx6325 fixup: reserve unreported resources

Dave Airlie
2010-12-12T05:23:21Z

On Sun, Dec 12, 2010 at 1:30 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Wed, Dec 8, 2010 at 1:36 PM, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
>>
>> The HP nx6325 BIOS doesn't report any devices in the [0xf8000000-0xfbffffff]
>> region via ACPI devices or the E820 memory map, but when we assign it to the
>> 00:14.4 bridge as a prefetchable memory window, the machine hangs.
>
> Quite frankly, I think this patch sucks.
>
> It sucks because these kinds of hw-specific patches are fundamentally
> a sign of something else being wrong. Why didn't windows hit this? Why
> do we need this total hack?
>
> And is there any reason at all to believe that that one particular
> laptop is really special? I doubt it. And what happens for the next
> random machine that comes along an hits this?
>
> Maybe we should just say that if we know the bridge is negative
> decode, and it hasn't been set up by the BIOS, we just don't allocate
> it at all. And try to look like Windows.
>
> Or figure out what else Windows is doing differently.
>
> The whole "allocate bottom up" old PCI allocation has _years_ of
> testing and quirk that have been gathered over a long time. We can't
> just say "we'll do the same thing for the top-down allocator".
>
> The WHOLE AND ONLY POINT of the top-down allocator was to act lik
> Windows and not need crap like this. If that doesn't work, then I
> seriously don't think we should change bottom-up to top-down at all,
> and for 2.6.37 we should just revert the "set to top-down by default".
>
> Seriously. That "whole and only point" thing is important. If we need
> hacks like this, then we shouldn't do it. We're much better off with
> the model that has year of testing an not the upheaval. Top-down
> allocation is in _no_ way inherently better, the only excuse for it
> was supposed to be "we don't need these kinds of hooks".

I agree, I've got an NX6125 predecessor of this and I'll take any
money that is has an equally insane BIOS, considering its the worst
laptop in my pile in nearly every way imaginable.

and I suspect the HP laptop braindamage won't end with those two.

Dave.