From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, Len Brown <lenb@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Adam Belay <abelay@mit.edu>
Subject: [PATCH 3/9] Revert "x86/PCI: allocate space from the end of a region, not the beginning"
Date: Thu, 16 Dec 2010 10:38:31 -0700 [thread overview]
Message-ID: <20101216173830.8185.85826.stgit@bob.kio> (raw)
In-Reply-To: <20101216173614.8185.19462.stgit@bob.kio>
This reverts commit dc9887dc02e37bcf83f4e792aa14b07782ef54cf.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
arch/x86/pci/i386.c | 17 ++++++-----------
1 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/arch/x86/pci/i386.c b/arch/x86/pci/i386.c
index c4bb261..8379c2c 100644
--- a/arch/x86/pci/i386.c
+++ b/arch/x86/pci/i386.c
@@ -65,21 +65,16 @@ pcibios_align_resource(void *data, const struct resource *res,
resource_size_t size, resource_size_t align)
{
struct pci_dev *dev = data;
- resource_size_t start = round_down(res->end - size + 1, align);
+ resource_size_t start = res->start;
if (res->flags & IORESOURCE_IO) {
-
- /*
- * If we're avoiding ISA aliases, the largest contiguous I/O
- * port space is 256 bytes. Clearing bits 9 and 10 preserves
- * all 256-byte and smaller alignments, so the result will
- * still be correctly aligned.
- */
- if (!skip_isa_ioresource_align(dev))
- start &= ~0x300;
+ if (skip_isa_ioresource_align(dev))
+ return start;
+ if (start & 0x300)
+ start = (start + 0x3ff) & ~0x3ff;
} else if (res->flags & IORESOURCE_MEM) {
if (start < BIOS_END)
- start = res->end; /* fail; no space */
+ start = BIOS_END;
}
return start;
}
next prev parent reply other threads:[~2010-12-16 17:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 17:38 [PATCH 0/9] PCI: revert to allocating bottom-up, avoid E820 areas Bjorn Helgaas
2010-12-16 17:38 ` [PATCH 1/9] Revert "PCI: fix pci_bus_alloc_resource() hang, prefer positive decode" Bjorn Helgaas
2010-12-16 17:38 ` [PATCH 2/9] Revert "x86: allocate space within a region top-down" Bjorn Helgaas
2010-12-16 17:38 ` Bjorn Helgaas [this message]
2010-12-16 17:38 ` [PATCH 4/9] Revert "PCI: allocate bus resources from the top down" Bjorn Helgaas
2010-12-16 17:38 ` [PATCH 5/9] Revert "resources: support allocating space within a region " Bjorn Helgaas
2010-12-16 17:38 ` [PATCH 6/9] resources: add arch hook for preventing allocation in reserved areas Bjorn Helgaas
2010-12-16 22:03 ` Linus Torvalds
2010-12-16 22:56 ` Bjorn Helgaas
2010-12-16 23:17 ` Linus Torvalds
2010-12-16 17:38 ` [PATCH 7/9] x86: avoid low BIOS area when allocating address space Bjorn Helgaas
2010-12-16 17:38 ` [PATCH 8/9] x86: avoid E820 regions " Bjorn Helgaas
2010-12-19 9:50 ` Yinghai Lu
2010-12-19 23:33 ` Bjorn Helgaas
2010-12-16 17:39 ` [PATCH 9/9] x86: avoid high BIOS area " Bjorn Helgaas
2010-12-16 21:59 ` [PATCH 0/9] PCI: revert to allocating bottom-up, avoid E820 areas Linus Torvalds
2010-12-16 22:03 ` Jesse Barnes
2010-12-17 3:00 ` H. Peter Anvin
2010-12-17 16:00 ` Bjorn Helgaas
2010-12-19 14:31 ` David John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216173830.8185.85826.stgit@bob.kio \
--to=bjorn.helgaas@hp.com \
--cc=abelay@mit.edu \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox