Re: [PATCH] PCI / PCIe: Clear Root PME Status bits during early resume

Rafael J. Wysocki
2010-12-19T12:54:47Z

On Sunday, December 19, 2010, Rafael J. Wysocki wrote:
> On Sunday, December 19, 2010, Rafael J. Wysocki wrote:
> > On Sunday, December 19, 2010, Matthew Wilcox wrote:
> > > On Sun, Dec 19, 2010 at 11:49:40AM +0100, Rafael J. Wysocki wrote:
> > > > in pci_pm_default_resume_early() and not in the port's resume
> > > > routine, because it's generally necessary even if the PCI Express
> > > > port driver is not used).
> > >
> > > We should make it impossible to not use the PCIe port driver.
> >
> > Actually, that's not correct. In some cases (e.g. _OSI doesn't allow us
>
> That should have been _OSC(), sorry.
>
> > to use PCIe native services), we simply can't use it (because it is unsafe
> > and leads to serious problems).

Well, in fact, scratch that. We can make it do nothing except for an early
resume routine doing the clearing of the Root PME Status bit in that cases.

I'll rework the patch in that direction.

Thanks,
Rafael