From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH] acpi: Update battery information on notification 0x81 Date: Mon, 3 Jan 2011 21:56:24 +0100 Message-ID: <201101032156.24402.rjw@sisk.pl> References: <1281990739-17912-1-git-send-email-mjg@redhat.com> <201012232323.42702.rjw@sisk.pl> <20110103175915.GA789@srcf.ucam.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from ogre.sisk.pl ([217.79.144.158]:53834 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971Ab1ACU5A (ORCPT ); Mon, 3 Jan 2011 15:57:00 -0500 In-Reply-To: <20110103175915.GA789@srcf.ucam.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Matthew Garrett Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, lenb@kernel.org On Monday, January 03, 2011, Matthew Garrett wrote: > On Thu, Dec 23, 2010 at 11:23:42PM +0100, Rafael J. Wysocki wrote: > > > As I've already said on IRC, I'd simply add a new function like: > > > > void acpi_battery_refresh(struct acpi_battery *battery) > > { > > if (!battery->bat.dev) > > return; > > acpi_battery_get_info(battery); > > /* The battery may have changed its reporting units */ > > sysfs_remove_battery(battery); > > sysfs_add_battery(battery); > > } > > > > and call it before acpi_battery_update() > > (a) in acpi_battery_resume() > > (b) in acpi_battery_notify() if event == ACPI_BATTERY_NOTIFY_INFO > > > > That would be more straightforward IMHO. > > That might be more reasonable. Want to send that, or shall I? I can do that. Thanks, Rafael