From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Linux-pm mailing list <linux-pm@lists.linux-foundation.org>,
"Brown, Len" <len.brown@intel.com>,
steiner@sgi.com,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Len Brown <lenb@kernel.org>
Subject: Re: suspend hangs at platform phase [was: mmotm 2010-12-23-16-58 uploaded]
Date: Tue, 4 Jan 2011 23:57:08 +0100 [thread overview]
Message-ID: <201101042357.08600.rjw@sisk.pl> (raw)
In-Reply-To: <4D234F8E.7080102@gmail.com>
On Tuesday, January 04, 2011, Jiri Slaby wrote:
> On 01/04/2011 02:40 PM, Jiri Slaby wrote:
> > On 12/24/2010 01:58 AM, akpm@linux-foundation.org wrote:
> >> The mm-of-the-moment snapshot 2010-12-23-16-58 has been uploaded to
> >
> > Hi, this kernel regresses with respect to suspend to ram in comparison
> > with mmotm 2010-12-16-14-56.
> >
> > This is OK:
> > echo devices > /sys/power/pm_test
> > pm-suspend
> > This hangs at suspend phase:
> > echo platform > /sys/power/pm_test
> > pm-suspend
Hmm. So it looks like _PTS hangs?
> > Note that this kernel is based on next-20101221. Should I try newer (and
> > clean) -next?
>
> Ok, bisected down to:
> 16dc39c98a6ca56a27f22f7ac6731d8223237a2e is first bad commit
> commit 16dc39c98a6ca56a27f22f7ac6731d8223237a2e
> Author: Len Brown <len.brown@intel.com>
> Date: Thu Dec 16 23:12:23 2010 -0500
>
> ACPI: use ioremap_cache()
>
> Although the temporary boot-time ACPI table mappings
> were set up with CPU caching enabled, the permanent table
> mappings and AML run-time region memory accesses were
> set up with ioremap(), which on x86 is a synonym for
> ioremap_nocache().
>
> Changing this to ioremap_cache() improves performance as
> seen when accessing the tables via acpidump,
> or /sys/firmware/acpi/tables. It should also improve
> AML run-time performance.
>
> No change on ia64.
>
> Reported-by: Jack Steiner <steiner@sgi.com>
> Signed-off-by: Len Brown <len.brown@intel.com>
>
> :040000 040000 be35c5e8f214f10f94688c1a27f33ecfb8505220
> 52581222d0edf190f160f3e5aa5d2c1af8e76988 M arch
> :040000 040000 ccdca0d41938b8312e946cde3c01c59b32d1c17c
> 96ccf2357f2ac4a31d19cc41f5728d9f87b6cac0 M drivers
>
> Revert of that patch fixes the problem.
Can you send a dmesg output and acpidump output from the failing system, please?
Rafael
next parent reply other threads:[~2011-01-04 22:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201012240132.oBO1W8Ub022207@imap1.linux-foundation.org>
[not found] ` <4D232352.2030809@gmail.com>
[not found] ` <4D234F8E.7080102@gmail.com>
2011-01-04 22:57 ` Rafael J. Wysocki [this message]
2011-01-05 21:36 ` suspend hangs at platform phase [was: mmotm 2010-12-23-16-58 uploaded] Jiri Slaby
2011-01-05 22:39 ` Rafael J. Wysocki
2011-01-05 22:46 ` Jiri Slaby
2011-01-05 23:28 ` Rafael J. Wysocki
2011-01-06 9:24 ` Jiri Slaby
2011-01-06 15:45 ` Rafael J. Wysocki
[not found] ` <1294305504-5787-1-git-send-email-jslaby@suse.cz>
2011-01-06 15:57 ` [PATCH 1/1] PM: fix oops in suspend/hibernate code Rafael J. Wysocki
2011-01-06 16:09 ` Jiri Slaby
2011-01-06 16:31 ` Jiri Slaby
2011-01-06 16:38 ` Rafael J. Wysocki
2011-01-06 21:01 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101042357.08600.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mm-commits@vger.kernel.org \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox