Re: [PATCH] cpuidle: Make cpuidle_enable_device() call poll_idle_init()

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Tuesday, January 11, 2011, Rafael J. Wysocki wrote:
> On Tuesday, January 11, 2011, Len Brown wrote:
> > >  /**
> > >   * cpuidle_enable_device - enables idle PM for a CPU
> > >   * @dev: the CPU
> > > @@ -176,6 +215,8 @@ int cpuidle_enable_device(struct cpuidle
> > >  		ret = __cpuidle_register_device(dev);
> > >  		if (ret)
> > >  			return ret;
> > > +	} else {
> > > +		poll_idle_init(dev);
> > >  	}
> > 
> > how about calling poll_idle_init() unconditionally here
> > and deleting the call to it from within __cpuidle_register_device()?
> 
> Fine by me, as long as poll_idle_init() is called before the conditional. :-)

In fact, it even doesn't need to be called before the conditional.

So fine by me anyway.

Thanks,
Rafael