Re: [PATCH 14/48] PM: Fix oops in suspend/hibernate code related to failing ioremap()

Randy Dunlap
2011-01-12T18:41:20Z

On Wed, 12 Jan 2011 19:39:19 +0100 Jiri Slaby wrote:

> On 01/12/2011 11:19 AM, Len Brown wrote:
> > @@ -271,7 +271,7 @@ static inline int suspend_nvs_register(unsigned long a, unsigned long b)
> > }
> > static inline int suspend_nvs_alloc(void) { return 0; }
> > static inline void suspend_nvs_free(void) {}
> > -static inline void suspend_nvs_save(void) {}
> > +static inline int suspend_nvs_save(void) {}
>
> Aiee, I've just noticed, this needs to return something, otherwise a
> warning is generated for !CONFIG_SUSPEND_NVS.
>
> What's better for you, a followup or resend?

Yeah, I just made a patch for that, but I'll leave it up to
you and Len to haggle about.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***