public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Jeff Chua <jeff.chua.linux@gmail.com>
Cc: Len Brown <len.brown@intel.com>,
	linux-pm@lists.linux-foundation.org,
	Jack Steiner <steiner@sgi.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [linux-pm] Resume from Memory very slow on 2.6.37+
Date: Tue, 18 Jan 2011 02:35:59 +0100	[thread overview]
Message-ID: <201101180235.59498.rjw@sisk.pl> (raw)
In-Reply-To: <AANLkTi=nGmW=3XGRzxJ1avbz-PcE_QSdVBddOM1yMiBh@mail.gmail.com>

On Tuesday, January 18, 2011, Jeff Chua wrote:
> On Tue, Jan 18, 2011 at 2:55 AM, Brown, Len <len.brown@intel.com> wrote:
> > added Linux-acpi to cc
> >
> > any difference if you boot with acpi_sleep=nonvs ?
> 
> That works.
> 
> On Tue, Jan 18, 2011 at 8:14 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> >> What happens if you replace the acpi_os_map_memory() in
> >> suspend_nvs_save() with ioremap_cache() and the acpi_os_unmap_memory() in
> >> suspend_nvs_free() with iounmap() ?
> >
> > IOW, can you please test if the patch below makes a difference?
> >  drivers/acpi/nvs.c |    6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> That works too.

Interesting.

Do you have CONFIG_RCU_CPU_STALL_DETECTOR set?  If not, please set it.  Then,
set CONFIG_RCU_CPU_STALL_TIMEOUT to something like 10 (in either case), run
a suspend-resume cycle and see if there are any CPU stalls reported in the
logs. 

We can avoid calling synchronize_rcu() in suspend_nvs_free(), but I'd like
to know _why_ it's stalling in there.

> Now I have another problem which might be totally unrelated. Just
> realized that my notebook can't suspend to "disk" ... used to work
> last week. So, something has changed as well. May be someone has
> already reported/fixed this.

Not that I know of.  What do you mean by "can't suspend"?

Rafael

  reply	other threads:[~2011-01-18  1:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AANLkTimBEnKTuR5aQyXvpZX8grQPw1eCaVgP-k9yBXhv@mail.gmail.com>
2011-01-17 18:55 ` Resume from Memory very slow on 2.6.37+ Brown, Len
2011-01-17 22:49 ` Rafael J. Wysocki
2011-01-18  0:14   ` [linux-pm] " Rafael J. Wysocki
2011-01-18  1:14     ` Jeff Chua
2011-01-18  1:35       ` Rafael J. Wysocki [this message]
2011-01-18  5:19         ` Jeff Chua
2011-01-18 20:20           ` Rafael J. Wysocki
2011-01-19  1:20             ` Jeff Chua
2011-01-19  1:38               ` Rafael J. Wysocki
2011-01-19 14:13                 ` Jeff Chua
2011-01-19 21:19                   ` Rafael J. Wysocki
2011-01-19 21:27                     ` [1/2] ACPI: Introduce acpi_os_ioremap() Rafael J. Wysocki
2011-01-19 21:27                     ` [2/2] ACPI / PM: Call suspend_nvs_free() earlier during resume Rafael J. Wysocki
2011-01-20  1:21                     ` [linux-pm] Resume from Memory very slow on 2.6.37+ Jeff Chua
2011-01-20  1:50                       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201101180235.59498.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=jeff.chua.linux@gmail.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=steiner@sgi.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox