From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 1/6] printk: Allocate kernel log buffer earlier Date: Thu, 20 Jan 2011 15:50:21 -0800 Message-ID: <20110120155021.c39387c3.akpm@linux-foundation.org> References: <20110119230106.341785959@gulag1.americas.sgi.com> <20110119230106.527741713@gulag1.americas.sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:36497 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755229Ab1ATXvF (ORCPT ); Thu, 20 Jan 2011 18:51:05 -0500 In-Reply-To: <20110119230106.527741713@gulag1.americas.sgi.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Mike Travis Cc: Ingo Molnar , Len Brown , "H. Peter Anvin" , Thomas Gleixner , Jack Steiner , Robin Holt , Lori Gilbertson , x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org On Wed, 19 Jan 2011 17:01:07 -0600 Mike Travis wrote: > On larger systems, because of the numerous ACPI, Bootmem and EFI > messages, the static log buffer overflows before the larger one > specified by the log_buf_len param is allocated. Minimize the > overflow by allocating the new log buffer as soon as possible. > > All arch's are covered by the "setup_log_buf" in start_kernel(). > The x86 arch allocates it right after bootmem is created. > > ... > > +void setup_log_buf(void); > > ... > > +void __init setup_log_buf(void) > It's a PITA but the declaration should have the __init tag as well. We have had at least one instance where failing to do this caused an arch (arm) to emit a short-mode address offset to a function which it thought was in the same section as the callsite. Only the target was in a different section from the callsite and the linker couldn't fit the needed offset into the operand.