RE: thermal: Avoid CONFIG_NET compile dependency

R, Durgadoss
2011-01-24T04:39:30Z

Hi Rui,

>
> IMO,
> enum events {
> THERMAL_AUX0,
> THERMAL_AUX1,
> THERMAL_CRITICAL,
> THERMAL_DEV_FAULT,
> };
> should not be included in the ifdef case.
>
> BTW: Durgadoss, what does THERMAL_AUX0 and THERMAL_AUX1 mean?
> Sorry I missed this in the original patch, but these two events do not
> look like something the generic thermal driver knows.
>
> If you really need these kind of events, I'd prefer something like this:
> enum events {
> THERMAL_CRITICAL,
> /* user defined thermal events */
> TEHRMAL_USER0,
> TEHRMAL_USER1,
> THERMAL_DEV_FAULT,
> };
>
> or
> enum events {
> THERMAL_CRITICAL,
> /* user defined thermal events */
> TEHRMAL_USER_AUX0,
> TEHRMAL_USER_AUX1,
> THERMAL_DEV_FAULT,
> };
>
>
> > Therefore please apply this one as it is.
> >
> which one? do I miss something again? :)
>

This refers to the patch that you acknowledged.
So, you are not missing any patch in the middle.

Also, the thermal_aux0 and _aux1, we can use the final format specified by you.
enum events {
THERMAL_CRITICAL,
/* user defined thermal events */
THERMAL_USER_AUX0,
THERMAL_USER_AUX1,
THERMAL_DEV_FAULT,
};
Thanks for the suggestion, Rui.

Regards,
Durga