Re: thermal: Avoid CONFIG_NET compile dependency

Zhang Rui
2011-01-24T01:24:05Z

On Fri, 2011-01-21 at 20:12 +0800, Thomas Renninger wrote:
> On Friday, January 21, 2011 11:52:39 AM R, Durgadoss wrote:
> > Hi Len,
> >
> > This patch from Thomas fixes the compile dependency.
> > Looks fine as far as I have tested.
> >
> > Could you please apply it on top of the old patch ?
> I tried to not export thermal_netlink_event in #ifndef CONFIG_NET
> case, but as it uses an enum which should only exist in CONFIG_NET
> case it doesn't work out that easy...
>
oh, right.

IMO,
enum events {
THERMAL_AUX0,
THERMAL_AUX1,
THERMAL_CRITICAL,
THERMAL_DEV_FAULT,
};
should not be included in the ifdef case.

BTW: Durgadoss, what does THERMAL_AUX0 and THERMAL_AUX1 mean?
Sorry I missed this in the original patch, but these two events do not
look like something the generic thermal driver knows.

If you really need these kind of events, I'd prefer something like this:
enum events {
THERMAL_CRITICAL,
/* user defined thermal events */
TEHRMAL_USER0,
TEHRMAL_USER1,
THERMAL_DEV_FAULT,
};

or
enum events {
THERMAL_CRITICAL,
/* user defined thermal events */
TEHRMAL_USER_AUX0,
TEHRMAL_USER_AUX1,
THERMAL_DEV_FAULT,
};

> Therefore please apply this one as it is.
>
which one? do I miss something again? :)

thanks,
rui

> Thanks,
>
> Thomas
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html