From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Renninger Subject: Re: thermal: Avoid CONFIG_NET compile dependency Date: Tue, 25 Jan 2011 17:18:36 +0100 Message-ID: <201101251718.36558.trenn@suse.de> References: <201101251048.43227.jdelvare@suse.de> <20110125134315.GA7301@ericsson.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from cantor2.suse.de ([195.135.220.15]:55556 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751307Ab1AYQSi (ORCPT ); Tue, 25 Jan 2011 11:18:38 -0500 In-Reply-To: <20110125134315.GA7301@ericsson.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Guenter Roeck Cc: Jean Delvare , "R, Durgadoss" , "Zhang, Rui" , Len Brown , "linux-acpi@vger.kernel.org" , "Yu, Fenghua" On Tuesday, January 25, 2011 02:43:15 PM Guenter Roeck wrote: > On Tue, Jan 25, 2011 at 04:48:43AM -0500, Jean Delvare wrote: > > On Tuesday 25 January 2011 05:47:56 am R, Durgadoss wrote: ... > > I don't remember the details, but one thing for sure if that you can't > > change the format of existing attributes the hwmon subsystem (and > > libsensors) is using. These are standardized per > > Documentation/hwmon/sysfs-interface, so they can't be changed. But there > > is no problem with registering a second class device with the thermal > > subsystem and adding whatever attributes you want to have there. > > > A secondary problem is that thermal subsystem drivers register themselves > with the hwmon subsystem - at least if CONFIG_THERMAL_HWMON is defined. > So it doesn't really make much sense for a driver to register itself > as thermal driver _and_ as hwmon driver, since it may end up being listed > twice as hwmon device. Having a very quick look at coretemp, this one only provides thermal data, right? So it should register as a thermal driver which in turn tells userspace that lsmsensors can retrieve data from it. The data would then get exported via: /sys/devices/virtual/thermal/ and the whole platform code can get removed. Do I miss something? Thomas