From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: matthieu castet <castet.matthieu@free.fr>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org
Subject: Re: [RFC] merge 32/64 bits realmode wakeup code
Date: Sat, 29 Jan 2011 22:15:57 +0100 [thread overview]
Message-ID: <201101292215.57292.rjw@sisk.pl> (raw)
In-Reply-To: <4D447C00.70709@free.fr>
On Saturday, January 29, 2011, matthieu castet wrote:
> Rafael J. Wysocki a écrit :
> > On Thursday, January 27, 2011, matthieu castet wrote:
> >> Hi,
> >>
> >> this patch merge 32 and 64 realmode wakeup code :
> >> - this mean less ifdef in code
> >> - we could remove now unused field in wakeup_header (pmode_*)
> >> - this allow to set the first 1 MB NX.
> >>
> >> Do you think it is safe on all X86 32 bit machine ?
> >>
> >> Matthieu
> >>
> >>
> >> Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>
> >
> > It _looks_ sane, but it will require some serious testing. I'm not sure,
> > though, if we can get enough testing coverage without actually committing
> > that change.
> >
> > How much testing has it received so far?
> >
> Not too much only qemu with 1 and 2 core and a laptop with 1 cpu.
>
> Please note that with this patch we can also remove the gdt, idt, ldt stuff from
> arch/x86/kernel/acpi/wakeup_32.S
That's correct, but those changes can wait. The most urgent thing is to fix
the resume regression at hand. I guess we should ask the reporter's in
https://bugzilla.kernel.org/show_bug.cgi?id=27472 to test that patch, right?
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-01-29 21:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 21:56 [RFC] merge 32/64 bits realmode wakeup code matthieu castet
2011-01-27 22:53 ` Rafael J. Wysocki
2011-01-29 20:43 ` matthieu castet
2011-01-29 21:15 ` Rafael J. Wysocki [this message]
2011-01-30 0:19 ` H. Peter Anvin
2011-01-30 12:59 ` Rafael J. Wysocki
2011-01-30 19:57 ` matthieu castet
2011-01-30 20:04 ` matthieu castet
2011-01-30 22:42 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101292215.57292.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=castet.matthieu@free.fr \
--cc=hpa@zytor.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox