From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: "rui.zhang@intel.com" <rui.zhang@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ACPI Devel Mailing List <linux-acpi@vger.kernel.org>,
Len Brown <lenb@kernel.org>
Subject: Re: 2.6.38-rc2: acpi backlight control missing
Date: Mon, 31 Jan 2011 23:01:29 +0100 [thread overview]
Message-ID: <201101312301.29434.rjw@sisk.pl> (raw)
In-Reply-To: <DB7A733A-D21A-4134-B50F-121CE2C179D3@m3y3r.de>
On Monday, January 31, 2011, Thomas Meyer wrote:
> Am 31.01.2011 um 21:39 schrieb "Rafael J. Wysocki" <rjw@sisk.pl>:
>
> > On Friday, January 28, 2011, Thomas Meyer wrote:
> >> Am Samstag, den 22.01.2011, 20:43 +0100 schrieb Rafael J. Wysocki:
> >>> On Saturday, January 22, 2011, Thomas Meyer wrote:
> >>>> with 2.6.38-rc2 the acpi backlight is gone:
> >>>>
> >>>> any ideas?
> >>>
> >>> Not really, but Matthew may have some (CCed).
> >>
> >> Okay, found the problem.
> >>
> >> This commit broke my backlight:
> >>
> >> commit 677bd810eedce61edf15452491781ff046b92edc
> >> Author: Zhang Rui <rui.zhang@intel.com>
> >> Date: Mon Dec 6 15:04:21 2010 +0800
> >>
> >> ACPI video: remove output switching control
> >>
> >> This is because in function
> >> "acpi_is_video_device()" (drivers/acpi/video_detect.c) the backlight
> >> device is only checked when some video capabilities were found, but by
> >> removing the check for the VIDEO_OUTPUT_SWITCHING (that seems to be the
> >> only video capability on my system) the check for the backlight device
> >> isn't done anymore.
> >>
> >> by reverting above commit, the backlight is back again.
> >
> > Is it the same issue as https://bugzilla.kernel.org/show_bug.cgi?id=27702 ?
>
> Yes, it is.
>
> > In case it is, can you test the patch in there, please?
> >
>
> Didn't test the patch. But it should do the trick.
Great, thanks!
Rafael
prev parent reply other threads:[~2011-01-31 22:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1295693349.2120.3.camel@localhost.localdomain>
2011-01-22 19:43 ` 2.6.38-rc2: acpi backlight control missing Rafael J. Wysocki
2011-01-26 18:01 ` Thomas Meyer
2011-01-28 21:12 ` Thomas Meyer
2011-01-31 20:39 ` Rafael J. Wysocki
2011-01-31 21:34 ` Thomas Meyer
2011-01-31 22:01 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101312301.29434.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox