From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 1/4] printk: Allocate kernel log buffer earlier Date: Sun, 27 Feb 2011 13:15:18 +0100 Message-ID: <20110227121518.GA19165@elte.hu> References: <20110225180633.857892225@gulag1.americas.sgi.com> <20110225180634.017570095@gulag1.americas.sgi.com> <20110227120949.GF16453@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx3.mail.elte.hu ([157.181.1.138]:36830 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751911Ab1B0MPf (ORCPT ); Sun, 27 Feb 2011 07:15:35 -0500 Content-Disposition: inline In-Reply-To: <20110227120949.GF16453@elte.hu> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Mike Travis Cc: David Rientjes , Jack Steiner , Robin Holt , Len Brown , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , Yinghai Lu , linux-acpi@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, Tejun Heo , Linus Torvalds , Yinghai Lu * Ingo Molnar wrote: > You could avoid all this ugly workaround of bootmem limitations by moving the > allocation to memblock_alloc() and desupporting the log_buf_len= boot parameter on > non-memblock architectures. memblock_alloc() could return -ENOSYS on architectures that do not implement it - thus enabling such optional features without ugly #ifdef CONFIG_HAVE_MEMBLOCK conditionals. Thanks, Ingo